From: Mingbao Sun <sunmingbao@tom.com>
To: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: sunmingbao@tom.com, tyler.sun@dell.com, ping.gan@dell.com,
yanxiu.cai@dell.com, libin.zhang@dell.com, ao.sun@dell.com
Subject: [PATCH 0/3] NVMe/TCP: support specifying the congestion-control
Date: Fri, 11 Mar 2022 11:01:10 +0800 [thread overview]
Message-ID: <20220311030113.73384-1-sunmingbao@tom.com> (raw)
From: Mingbao Sun <tyler.sun@dell.com>
Hi all,
congestion-control could have a noticeable impaction on the
performance of TCP-based communications. This is of course true
to NVMe_over_TCP.
Different congestion-controls (e.g., cubic, dctcp) are suitable for
different scenarios. Proper adoption of congestion control would benefit
the performance. On the contrary, the performance could be destroyed.
Though we can specify the congestion-control of NVMe_over_TCP via
writing '/proc/sys/net/ipv4/tcp_congestion_control', but this also
changes the congestion-control of all the future TCP sockets that
have not been explicitly assigned the congestion-control, thus bringing
potential impaction on their performance.
So it makes sense to make NVMe_over_TCP support specifying the
congestion-control.
patch 1/3 export a symbol on behalf of the following ones.
patch 2/3 addresses the NVMe/TCP host side.
patch 3/3 addresses the NVMe/TCP target side.
Since the change made to netdev is pretty simple, so the patch
is generated against nvme-5.18 of the nvme.git.
Mingbao Sun (3):
tcp: export symbol tcp_set_congestion_control
nvme-tcp: support specifying the congestion-control
nvmet-tcp: support specifying the congestion-control
drivers/nvme/host/fabrics.c | 12 +++++++++++
drivers/nvme/host/fabrics.h | 2 ++
drivers/nvme/host/tcp.c | 15 +++++++++++++-
drivers/nvme/target/configfs.c | 37 ++++++++++++++++++++++++++++++++++
drivers/nvme/target/nvmet.h | 1 +
drivers/nvme/target/tcp.c | 11 ++++++++++
net/ipv4/tcp_cong.c | 1 +
7 files changed, 78 insertions(+), 1 deletion(-)
--
2.26.2
next reply other threads:[~2022-03-11 3:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 3:01 Mingbao Sun [this message]
2022-03-11 3:01 ` [PATCH 1/3] tcp: export symbol tcp_set_congestion_control Mingbao Sun
2022-03-11 7:13 ` Christoph Hellwig
2022-03-11 8:39 ` Mingbao Sun
2022-03-11 3:01 ` [PATCH 2/3] nvme-tcp: support specifying the congestion-control Mingbao Sun
2022-03-11 7:15 ` Christoph Hellwig
2022-03-11 8:47 ` Mingbao Sun
2022-03-11 3:01 ` [PATCH 3/3] nvmet-tcp: " Mingbao Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220311030113.73384-1-sunmingbao@tom.com \
--to=sunmingbao@tom.com \
--cc=ao.sun@dell.com \
--cc=axboe@fb.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=kuba@kernel.org \
--cc=libin.zhang@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=ping.gan@dell.com \
--cc=sagi@grimberg.me \
--cc=tyler.sun@dell.com \
--cc=yanxiu.cai@dell.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®