From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: <linux-kernel@vger.kernel.org>
Cc: <kernel@axis.com>,
Vincent Whitchurch <vincent.whitchurch@axis.com>,
<devicetree@vger.kernel.org>, <linux-um@lists.infradead.org>,
<shuah@kernel.org>, <brendanhiggins@google.com>,
<linux-kselftest@vger.kernel.org>, <jic23@kernel.org>,
<linux-iio@vger.kernel.org>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <a.zummo@towertech.it>,
<alexandre.belloni@bootlin.com>, <linux-rtc@vger.kernel.org>,
<corbet@lwn.net>, <linux-doc@vger.kernel.org>
Subject: [RFC v1 07/10] iio: light: opt3001: add roadtest
Date: Fri, 11 Mar 2022 17:24:42 +0100 [thread overview]
Message-ID: <20220311162445.346685-8-vincent.whitchurch@axis.com> (raw)
In-Reply-To: <20220311162445.346685-1-vincent.whitchurch@axis.com>
Add a regression test for the problem fixed by the following patch,
which would require specific environmental conditions to be able to be
reproduced and regression-tested on real hardware:
iio: light: opt3001: Fixed timeout error when 0 lux
https://lore.kernel.org/lkml/20210920125351.6569-1-valek@2n.cz/
No other aspects of the driver are tested.
Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
---
.../roadtest/roadtest/tests/iio/__init__.py | 0
.../roadtest/roadtest/tests/iio/config | 1 +
.../roadtest/tests/iio/light/__init__.py | 0
.../roadtest/roadtest/tests/iio/light/config | 1 +
.../roadtest/tests/iio/light/test_opt3001.py | 95 +++++++++++++++++++
5 files changed, 97 insertions(+)
create mode 100644 tools/testing/roadtest/roadtest/tests/iio/__init__.py
create mode 100644 tools/testing/roadtest/roadtest/tests/iio/config
create mode 100644 tools/testing/roadtest/roadtest/tests/iio/light/__init__.py
create mode 100644 tools/testing/roadtest/roadtest/tests/iio/light/config
create mode 100644 tools/testing/roadtest/roadtest/tests/iio/light/test_opt3001.py
diff --git a/tools/testing/roadtest/roadtest/tests/iio/__init__.py b/tools/testing/roadtest/roadtest/tests/iio/__init__.py
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tools/testing/roadtest/roadtest/tests/iio/config b/tools/testing/roadtest/roadtest/tests/iio/config
new file mode 100644
index 000000000000..a08d9e23ce38
--- /dev/null
+++ b/tools/testing/roadtest/roadtest/tests/iio/config
@@ -0,0 +1 @@
+CONFIG_IIO=y
diff --git a/tools/testing/roadtest/roadtest/tests/iio/light/__init__.py b/tools/testing/roadtest/roadtest/tests/iio/light/__init__.py
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tools/testing/roadtest/roadtest/tests/iio/light/config b/tools/testing/roadtest/roadtest/tests/iio/light/config
new file mode 100644
index 000000000000..b9753f2d0728
--- /dev/null
+++ b/tools/testing/roadtest/roadtest/tests/iio/light/config
@@ -0,0 +1 @@
+CONFIG_OPT3001=m
diff --git a/tools/testing/roadtest/roadtest/tests/iio/light/test_opt3001.py b/tools/testing/roadtest/roadtest/tests/iio/light/test_opt3001.py
new file mode 100644
index 000000000000..abf20b8f3516
--- /dev/null
+++ b/tools/testing/roadtest/roadtest/tests/iio/light/test_opt3001.py
@@ -0,0 +1,95 @@
+# SPDX-License-Identifier: GPL-2.0-only
+# Copyright Axis Communications AB
+
+from typing import Any, Final
+
+from roadtest.backend.i2c import SMBusModel
+from roadtest.core.devicetree import DtFragment, DtVar
+from roadtest.core.hardware import Hardware
+from roadtest.core.modules import insmod, rmmod
+from roadtest.core.suite import UMLTestCase
+from roadtest.core.sysfs import I2CDriver, read_float
+
+REG_RESULT: Final = 0x00
+REG_CONFIGURATION: Final = 0x01
+REG_LOW_LIMIT: Final = 0x02
+REG_HIGH_LIMIT: Final = 0x03
+REG_MANUFACTURER_ID: Final = 0x7E
+REG_DEVICE_ID: Final = 0x7F
+
+REG_CONFIGURATION_CRF: Final = 1 << 7
+
+
+class OPT3001(SMBusModel):
+ def __init__(self, **kwargs: Any) -> None:
+ super().__init__(regbytes=2, byteorder="big", **kwargs)
+ # Reset values from datasheet
+ self.regs = {
+ REG_RESULT: 0x0000,
+ REG_CONFIGURATION: 0xC810,
+ REG_LOW_LIMIT: 0xC000,
+ REG_HIGH_LIMIT: 0xBFFF,
+ REG_MANUFACTURER_ID: 0x5449,
+ REG_DEVICE_ID: 0x3001,
+ }
+
+ def reg_read(self, addr: int) -> int:
+ val = self.regs[addr]
+
+ if addr == REG_CONFIGURATION:
+ # Always indicate that the conversion is ready. This is good
+ # enough for our current purposes.
+ val |= REG_CONFIGURATION_CRF
+
+ return val
+
+ def reg_write(self, addr: int, val: int) -> None:
+ assert addr in self.regs
+ self.regs[addr] = val
+
+
+class TestOPT3001(UMLTestCase):
+ dts = DtFragment(
+ src="""
+&i2c {
+ light-sensor@$addr$ {
+ compatible = "ti,opt3001";
+ reg = <0x$addr$>;
+ };
+};
+ """,
+ variables={
+ "addr": DtVar.I2C_ADDR,
+ },
+ )
+
+ @classmethod
+ def setUpClass(cls) -> None:
+ insmod("opt3001")
+
+ @classmethod
+ def tearDownClass(cls) -> None:
+ rmmod("opt3001")
+
+ def setUp(self) -> None:
+ self.driver = I2CDriver("opt3001")
+ self.hw = Hardware("i2c")
+ self.hw.load_model(OPT3001)
+
+ def tearDown(self) -> None:
+ self.hw.close()
+
+ def test_illuminance(self) -> None:
+ data = [
+ # Some values from datasheet, and 0
+ (0b_0000_0000_0000_0000, 0),
+ (0b_0000_0000_0000_0001, 0.01),
+ (0b_0011_0100_0101_0110, 88.80),
+ (0b_0111_1000_1001_1010, 2818.56),
+ ]
+ with self.driver.bind(self.dts["addr"]) as dev:
+ luxfile = dev.path / "iio:device0/in_illuminance_input"
+
+ for regval, lux in data:
+ self.hw.reg_write(REG_RESULT, regval)
+ self.assertEqual(read_float(luxfile), lux)
--
2.34.1
next prev parent reply other threads:[~2022-03-11 16:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 16:24 [RFC v1 00/10] roadtest: a driver testing framework Vincent Whitchurch
2022-03-11 16:24 ` [RFC v1 01/10] roadtest: import libvhost-user from QEMU Vincent Whitchurch
2022-03-24 13:00 ` Johannes Berg
2022-04-05 13:54 ` Vincent Whitchurch
2022-03-11 16:24 ` [RFC v1 02/10] roadtest: add C backend Vincent Whitchurch
2022-03-11 16:24 ` [RFC v1 03/10] roadtest: add framework Vincent Whitchurch
2022-03-11 16:24 ` [RFC v1 04/10] roadtest: add base config Vincent Whitchurch
2022-03-11 16:24 ` [RFC v1 05/10] roadtest: add build files Vincent Whitchurch
2022-03-11 16:24 ` [RFC v1 06/10] roadtest: add documentation Vincent Whitchurch
2022-03-11 16:24 ` Vincent Whitchurch [this message]
2022-03-14 23:11 ` [RFC v1 07/10] iio: light: opt3001: add roadtest Brendan Higgins
2022-03-18 15:49 ` Vincent Whitchurch
2022-03-18 20:09 ` Johannes Berg
2022-03-29 14:43 ` Vincent Whitchurch
2022-03-29 14:50 ` Johannes Berg
2022-03-29 14:52 ` Johannes Berg
2022-03-11 16:24 ` [RFC v1 08/10] iio: light: vcnl4000: " Vincent Whitchurch
2022-03-20 17:02 ` Jonathan Cameron
2022-04-05 13:48 ` Vincent Whitchurch
2022-04-06 13:08 ` Jonathan Cameron
2022-04-14 10:20 ` Vincent Whitchurch
2022-03-11 16:24 ` [RFC v1 09/10] regulator: tps62864: " Vincent Whitchurch
2022-03-11 18:06 ` Mark Brown
2022-03-17 15:13 ` Vincent Whitchurch
2022-03-17 17:53 ` Mark Brown
2022-04-05 14:02 ` Vincent Whitchurch
2022-03-11 16:24 ` [RFC v1 10/10] rtc: pcf8563: " Vincent Whitchurch
2022-03-14 22:24 ` [RFC v1 00/10] roadtest: a driver testing framework Brendan Higgins
2022-03-17 16:09 ` Vincent Whitchurch
2022-04-18 19:44 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220311162445.346685-8-vincent.whitchurch@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=brendanhiggins@google.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kernel@axis.com \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®