From: Ritesh Harjani <riteshh@linux.ibm.com>
To: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4/053: Add support for testing mb_optimize_scan
Date: Mon, 14 Mar 2022 19:50:46 +0530 [thread overview]
Message-ID: <20220314142030.aigttj2likaqtz2c@riteshh-domain> (raw)
In-Reply-To: <5b0d252484cbe973c2df0c677cb47b30012b0db1.1647253313.git.ojaswin@linux.ibm.com>
On 22/03/14 04:02PM, Ojaswin Mujoo wrote:
> Add support to test the mb_optimize_scan mount option.
> Since its value is not reflected in the "options" file in proc,
> use "mb_structs_summary" to verify its value.
Yes, I think we can do this. Thanks for identifying it.
>
> Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Overall the patch looks good to me. Feel free to add
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
> ---
> tests/ext4/053 | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)
<Some stats>
I ran this test of yours with and w/o your kernel fix for this mount option,
which is now sitting in ext4 dev tree [1].
<with kernel fix>
ext4/053 173s ... 147s
Ran: ext4/053
Passed all 1 tests
<w/o kernel fix>
ext4/053 173s ... [failed, exit status 2]- output mismatch (see /home/qemu/work/tools/xfstests-dev/results//ext4_4k/ext4/053.out.bad)
--- tests/ext4/053.out 2022-01-03 11:50:08.671463501 +0530
+++ /home/qemu/work/tools/xfstests-dev/results//ext4_4k/ext4/053.out.bad 2022-03-14 18:26:12.290610687 +0530
@@ -1,2 +1,4 @@
QA output created by 053
Silence is golden.
+mounting ext3 "mb_optimize_scan=1" checking "mb_optimize_scan=1" (not found) FAILED
+mounting ext4 "mb_optimize_scan=1" checking "mb_optimize_scan=1" (not found) FAILED
...
(Run 'diff -u /home/qemu/work/tools/xfstests-dev/tests/ext4/053.out /home/qemu/work/tools/xfstests-dev/results//ext4_4k/ext4/053.out.bad' to see the entire diff)
Ran: ext4/053
Failures: ext4/053
Failed 1 of 1 tests
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=27b38686a3bb601db48901dbc4e2fc5d77ffa2c1
next prev parent reply other threads:[~2022-03-14 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 10:32 Ojaswin Mujoo
2022-03-14 14:20 ` Ritesh Harjani [this message]
2022-04-10 12:48 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220314142030.aigttj2likaqtz2c@riteshh-domain \
--to=riteshh@linux.ibm.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®