From: Moudy Ho <moudy.ho@mediatek.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Jernej Skrabec <jernej.skrabec@siol.net>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Rob Landley <rob@landley.net>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Alexandre Courbot <acourbot@chromium.org>, <tfiga@chromium.org>,
<drinkcat@chromium.org>, <pihsun@chromium.org>,
<hsinyi@google.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Maoguang Meng <maoguang.meng@mediatek.com>,
daoyuan huang <daoyuan.huang@mediatek.com>,
Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
<menghui.lin@mediatek.com>, <sj.huang@mediatek.com>,
<allen-kh.cheng@mediatek.com>, <randy.wu@mediatek.com>,
<moudy.ho@mediatek.com>, <jason-jh.lin@mediatek.com>,
<roy-cw.yeh@mediatek.com>, <river.cheng@mediatek.com>,
<srv_heupstream@mediatek.com>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: [PATCH v13 1/6] soc: mediatek: mutex: add common interface to accommodate multiple modules operationg MUTEX
Date: Tue, 15 Mar 2022 14:10:26 +0800 [thread overview]
Message-ID: <20220315061031.21642-2-moudy.ho@mediatek.com> (raw)
In-Reply-To: <20220315061031.21642-1-moudy.ho@mediatek.com>
In order to allow multiple modules to operate MUTEX hardware through
a common interfrace, a flexible index "mtk_mutex_table_index" needs to
be added to replace original component ID so that like DDP and MDP
can add their own MUTEX table settings independently.
In addition, 4 generic interface "mtk_mutex_set_mod", "mtk_mutex_set_sof",
"mtk_mutex_clear_mod" and "mtk_mutex_clear_sof" have been added, which is
expected to replace the "mtk_mutex_add_comp" and "mtk_mutex_remove_comp"
pair originally dedicated to DDP in the future.
Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
---
drivers/soc/mediatek/mtk-mutex.c | 122 +++++++++++++++++++++++++
include/linux/soc/mediatek/mtk-mutex.h | 33 +++++++
2 files changed, 155 insertions(+)
diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c
index aaf8fc1abb43..778b01ce9e8f 100644
--- a/drivers/soc/mediatek/mtk-mutex.c
+++ b/drivers/soc/mediatek/mtk-mutex.c
@@ -156,6 +156,7 @@ struct mtk_mutex_data {
const unsigned int *mutex_sof;
const unsigned int mutex_mod_reg;
const unsigned int mutex_sof_reg;
+ const unsigned long long *mutex_table_mod;
const bool no_clk;
};
@@ -445,6 +446,84 @@ void mtk_mutex_add_comp(struct mtk_mutex *mutex,
}
EXPORT_SYMBOL_GPL(mtk_mutex_add_comp);
+void mtk_mutex_set_mod(struct mtk_mutex *mutex,
+ enum mtk_mutex_table_index idx)
+{
+ struct mtk_mutex_ctx *mtx = container_of(mutex, struct mtk_mutex_ctx,
+ mutex[mutex->id]);
+ unsigned int reg;
+ unsigned int offset;
+
+ WARN_ON(&mtx->mutex[mutex->id] != mutex);
+
+ if (idx == MUTEX_TABLE_IDX_NONE ||
+ idx >= MUTEX_TABLE_IDX_MAX)
+ return;
+
+ if (mtx->data->mutex_table_mod[idx] <= BIT(31)) {
+ offset = DISP_REG_MUTEX_MOD(mtx->data->mutex_mod_reg,
+ mutex->id);
+ reg = readl_relaxed(mtx->regs + offset);
+ reg |= mtx->data->mutex_table_mod[idx];
+ writel_relaxed(reg, mtx->regs + offset);
+ } else {
+ offset = DISP_REG_MUTEX_MOD2(mutex->id);
+ reg = readl_relaxed(mtx->regs + offset);
+ reg |= (mtx->data->mutex_table_mod[idx] >> 32);
+ writel_relaxed(reg, mtx->regs + offset);
+ }
+}
+EXPORT_SYMBOL_GPL(mtk_mutex_set_mod);
+
+void mtk_mutex_set_sof(struct mtk_mutex *mutex,
+ enum mtk_mutex_table_index idx)
+{
+ struct mtk_mutex_ctx *mtx = container_of(mutex, struct mtk_mutex_ctx,
+ mutex[mutex->id]);
+ unsigned int sof_id;
+
+ WARN_ON(&mtx->mutex[mutex->id] != mutex);
+
+ if (idx == MUTEX_TABLE_IDX_NONE ||
+ idx >= MUTEX_TABLE_IDX_MAX)
+ return;
+
+ switch (idx) {
+ case MUTEX_TABLE_IDX_DDP_DSI0:
+ sof_id = MUTEX_SOF_DSI0;
+ break;
+ case MUTEX_TABLE_IDX_DDP_DSI1:
+ sof_id = MUTEX_SOF_DSI0;
+ break;
+ case MUTEX_TABLE_IDX_DDP_DSI2:
+ sof_id = MUTEX_SOF_DSI2;
+ break;
+ case MUTEX_TABLE_IDX_DDP_DSI3:
+ sof_id = MUTEX_SOF_DSI3;
+ break;
+ case MUTEX_TABLE_IDX_DDP_DPI0:
+ sof_id = MUTEX_SOF_DPI0;
+ break;
+ case MUTEX_TABLE_IDX_DDP_DPI1:
+ sof_id = MUTEX_SOF_DPI1;
+ break;
+ case MUTEX_TABLE_IDX_DDP_DP_INTF0:
+ sof_id = MUTEX_SOF_DP_INTF0;
+ break;
+ case MUTEX_TABLE_IDX_DDP_DP_INTF1:
+ sof_id = MUTEX_SOF_DP_INTF1;
+ break;
+ default:
+ sof_id = MUTEX_SOF_SINGLE_MODE;
+ break;
+ }
+
+ writel_relaxed(mtx->data->mutex_sof[sof_id],
+ mtx->regs +
+ DISP_REG_MUTEX_SOF(mtx->data->mutex_sof_reg, mutex->id));
+}
+EXPORT_SYMBOL_GPL(mtk_mutex_set_sof);
+
void mtk_mutex_remove_comp(struct mtk_mutex *mutex,
enum mtk_ddp_comp_id id)
{
@@ -485,6 +564,49 @@ void mtk_mutex_remove_comp(struct mtk_mutex *mutex,
}
EXPORT_SYMBOL_GPL(mtk_mutex_remove_comp);
+void mtk_mutex_clear_mod(struct mtk_mutex *mutex,
+ enum mtk_mutex_table_index idx)
+{
+ struct mtk_mutex_ctx *mtx = container_of(mutex, struct mtk_mutex_ctx,
+ mutex[mutex->id]);
+ unsigned int reg;
+ unsigned int offset;
+
+ WARN_ON(&mtx->mutex[mutex->id] != mutex);
+
+ if (idx == MUTEX_TABLE_IDX_NONE ||
+ idx >= MUTEX_TABLE_IDX_MAX)
+ return;
+
+ if (mtx->data->mutex_table_mod[idx] <= BIT(31)) {
+ offset = DISP_REG_MUTEX_MOD(mtx->data->mutex_mod_reg,
+ mutex->id);
+ reg = readl_relaxed(mtx->regs + offset);
+ reg &= ~(mtx->data->mutex_table_mod[idx]);
+ writel_relaxed(reg, mtx->regs + offset);
+ } else {
+ offset = DISP_REG_MUTEX_MOD2(mutex->id);
+ reg = readl_relaxed(mtx->regs + offset);
+ reg &= ~(mtx->data->mutex_table_mod[idx] >> 32);
+ writel_relaxed(reg, mtx->regs + offset);
+ }
+}
+EXPORT_SYMBOL_GPL(mtk_mutex_clear_mod);
+
+void mtk_mutex_clear_sof(struct mtk_mutex *mutex)
+{
+ struct mtk_mutex_ctx *mtx = container_of(mutex, struct mtk_mutex_ctx,
+ mutex[mutex->id]);
+
+ WARN_ON(&mtx->mutex[mutex->id] != mutex);
+
+ writel_relaxed(MUTEX_SOF_SINGLE_MODE,
+ mtx->regs +
+ DISP_REG_MUTEX_SOF(mtx->data->mutex_sof_reg,
+ mutex->id));
+}
+EXPORT_SYMBOL_GPL(mtk_mutex_clear_sof);
+
void mtk_mutex_enable(struct mtk_mutex *mutex)
{
struct mtk_mutex_ctx *mtx = container_of(mutex, struct mtk_mutex_ctx,
diff --git a/include/linux/soc/mediatek/mtk-mutex.h b/include/linux/soc/mediatek/mtk-mutex.h
index 6fe4ffbde290..c8355bb0e6d6 100644
--- a/include/linux/soc/mediatek/mtk-mutex.h
+++ b/include/linux/soc/mediatek/mtk-mutex.h
@@ -10,14 +10,47 @@ struct regmap;
struct device;
struct mtk_mutex;
+enum mtk_mutex_table_index {
+ MUTEX_TABLE_IDX_NONE = 0, /* Invalid engine */
+
+ /* MDP table index */
+ MUTEX_TABLE_IDX_MDP_RDMA0,
+ MUTEX_TABLE_IDX_MDP_RSZ0,
+ MUTEX_TABLE_IDX_MDP_RSZ1,
+ MUTEX_TABLE_IDX_MDP_TDSHP0,
+ MUTEX_TABLE_IDX_MDP_WROT0,
+ MUTEX_TABLE_IDX_MDP_WDMA,
+ MUTEX_TABLE_IDX_MDP_AAL0,
+ MUTEX_TABLE_IDX_MDP_CCORR0,
+
+ /* DDP table index */
+ MUTEX_TABLE_IDX_DDP_DSI0,
+ MUTEX_TABLE_IDX_DDP_DSI1,
+ MUTEX_TABLE_IDX_DDP_DSI2,
+ MUTEX_TABLE_IDX_DDP_DSI3,
+ MUTEX_TABLE_IDX_DDP_DPI0,
+ MUTEX_TABLE_IDX_DDP_DPI1,
+ MUTEX_TABLE_IDX_DDP_DP_INTF0,
+ MUTEX_TABLE_IDX_DDP_DP_INTF1,
+
+ MUTEX_TABLE_IDX_MAX /* ALWAYS keep at the end */
+};
+
struct mtk_mutex *mtk_mutex_get(struct device *dev);
int mtk_mutex_prepare(struct mtk_mutex *mutex);
void mtk_mutex_add_comp(struct mtk_mutex *mutex,
enum mtk_ddp_comp_id id);
+void mtk_mutex_set_mod(struct mtk_mutex *mutex,
+ enum mtk_mutex_table_index idx);
+void mtk_mutex_set_sof(struct mtk_mutex *mutex,
+ enum mtk_mutex_table_index idx);
void mtk_mutex_enable(struct mtk_mutex *mutex);
void mtk_mutex_disable(struct mtk_mutex *mutex);
void mtk_mutex_remove_comp(struct mtk_mutex *mutex,
enum mtk_ddp_comp_id id);
+void mtk_mutex_clear_mod(struct mtk_mutex *mutex,
+ enum mtk_mutex_table_index idx);
+void mtk_mutex_clear_sof(struct mtk_mutex *mutex);
void mtk_mutex_unprepare(struct mtk_mutex *mutex);
void mtk_mutex_put(struct mtk_mutex *mutex);
void mtk_mutex_acquire(struct mtk_mutex *mutex);
--
2.18.0
next prev parent reply other threads:[~2022-03-15 6:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 6:10 [PATCH v13 0/6] Add mutex support for MDP Moudy Ho
2022-03-15 6:10 ` Moudy Ho [this message]
2022-03-15 9:10 ` [PATCH v13 1/6] soc: mediatek: mutex: add common interface to accommodate multiple modules operationg MUTEX AngeloGioacchino Del Regno
2022-03-15 14:41 ` Rob Landley
2022-03-15 14:50 ` Geert Uytterhoeven
2022-03-15 14:58 ` AngeloGioacchino Del Regno
2022-03-16 2:25 ` CK Hu
2022-03-15 6:10 ` [PATCH v13 2/6] soc: mediatek: mutex: add 8183 MUTEX MOD settings for MDP Moudy Ho
2022-03-15 9:11 ` AngeloGioacchino Del Regno
2022-03-16 3:31 ` CK Hu
2022-03-15 6:10 ` [PATCH v13 3/6] dt-bindings: soc: mediatek: move out common module from display folder Moudy Ho
2022-03-15 9:11 ` AngeloGioacchino Del Regno
2022-03-15 6:10 ` [PATCH v13 4/6] dt-bindings: soc: mediatek: add gce-client-reg for MUTEX Moudy Ho
2022-03-15 9:12 ` AngeloGioacchino Del Regno
2022-03-16 3:50 ` CK Hu
2022-03-15 6:10 ` [PATCH v13 5/6] dts: arm64: mt8183: add GCE client property for Mediatek MUTEX Moudy Ho
2022-03-15 9:12 ` AngeloGioacchino Del Regno
2022-03-15 6:10 ` [PATCH v13 6/6] soc: mediatek: mutex: add functions that operate registers by CMDQ Moudy Ho
2022-03-15 9:13 ` AngeloGioacchino Del Regno
2022-03-17 3:39 ` CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220315061031.21642-2-moudy.ho@mediatek.com \
--to=moudy.ho@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=acourbot@chromium.org \
--cc=allen-kh.cheng@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daoyuan.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=geert+renesas@glider.be \
--cc=hsinyi@google.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jason-jh.lin@mediatek.com \
--cc=jernej.skrabec@siol.net \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maoguang.meng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=menghui.lin@mediatek.com \
--cc=pihsun@chromium.org \
--cc=ping-hsun.wu@mediatek.com \
--cc=randy.wu@mediatek.com \
--cc=river.cheng@mediatek.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=roy-cw.yeh@mediatek.com \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®