From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75E3EC433F5 for ; Wed, 16 Mar 2022 02:49:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353339AbiCPCuN (ORCPT ); Tue, 15 Mar 2022 22:50:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353332AbiCPCuI (ORCPT ); Tue, 15 Mar 2022 22:50:08 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0C2E12ADF for ; Tue, 15 Mar 2022 19:48:53 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id h2so1974954pfh.6 for ; Tue, 15 Mar 2022 19:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=c0M/K+1eFLxLow4mbMiKmCtwBH2b7Lm5/YgoYLc2Jig=; b=ccnR7riMJqNwgZKJTM2DdghxvC0pBG+VaqFAgWWSVY3XbJo1wzpiYHpMGXq6otq1N5 iV8gtOwV9NKjqsLy/hqESzwgOkqPUwSvvHuU1SEZFxe1rNeyGRIg+UIJQLfaOLdcICtO tv3bmG2kU2UvPdFt56vzYO6xr5RC+UdbajNEk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=c0M/K+1eFLxLow4mbMiKmCtwBH2b7Lm5/YgoYLc2Jig=; b=q2YRBwoYp62iq1BZTr7rdR4MBJl6SReGLuBmugfDx+NFMiVUKSQBKwG6izH5C0qzlP C9AJQLfXbRoc479NuoUgKpgmy9t4nOmARAP7goOyD8b7q7Jox1d2rrSzJru1d8OcCqsp YWckYULDc/3/XGC9iHpWqvP+sWarii1IPOnNFmcIqHZngVY1i4kwRg+zwmRCykTva9jM 8fnOqfxfbFypXCY78R0RhNxTK59OyYNaH0wAgbY3rZhlA6bSw/kIc0Gq0BZS2As6RZMM 8rxFAz5j4bAKf+PJ4ZRU+1BeC+dxE6Fcl6kg6AWjN3r0/a24I4u1m+s2czxSqXqVdqHb LuIw== X-Gm-Message-State: AOAM530IbGz1LVxM4wEL4VfycpKKa6OZ8AoozBfz+cpgwbGBUTofxKlq cS4CAszxkaKi5JovOyoH6c0W+A== X-Google-Smtp-Source: ABdhPJzVMfVBFpio8c9aEyIZlnXkq8spdnH7j/vo6Y0rcslj0Xy3iCQRbPgKW1yb2pCz+OY5DqegAg== X-Received: by 2002:a05:6a00:1350:b0:4f7:8c4f:cfca with SMTP id k16-20020a056a00135000b004f78c4fcfcamr24609313pfu.45.1647398933483; Tue, 15 Mar 2022 19:48:53 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id k3-20020a056a00168300b004f7e60da26csm503648pfc.182.2022.03.15.19.48.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 19:48:53 -0700 (PDT) Date: Tue, 15 Mar 2022 19:48:52 -0700 From: Kees Cook To: "Edgecombe, Rick P" Cc: "linux-kernel@vger.kernel.org" , "viro@zeniv.linux.org.uk" , "Williams, Dan J" , "Wysocki, Rafael J" , "ebiederm@xmission.com" , "Chatre, Reinette" , "linux-fsdevel@vger.kernel.org" , "Luck, Tony" , "Hansen, Dave" , "Brown, Len" Subject: Re: [PATCH 1/3] x86: Separate out x86_regset for 32 and 64 bit Message-ID: <202203151948.E5076F4BB@keescook> References: <20220315201706.7576-1-rick.p.edgecombe@intel.com> <20220315201706.7576-2-rick.p.edgecombe@intel.com> <202203151340.7447F75BDC@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 15, 2022 at 09:53:13PM +0000, Edgecombe, Rick P wrote: > On Tue, 2022-03-15 at 13:41 -0700, Kees Cook wrote: > > Have you verified there's no binary difference in machine code > > output? > > There actually was a different in the binaries. I investigated a bit, > and it seemed at least part of it was due to the line numbers changing > the WARN_ON()s. But otherwise, I assumed some compiler optimization > must have been bumped. Right, you can ignore all the debugging line number changes. "diffoscope" should help see the difference by section. As long as the actual object code isn't changing, you should be good. -- Kees Cook