From: Jeffle Xu <jefflexu@linux.alibaba.com>
To: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org,
chao@kernel.org, linux-erofs@lists.ozlabs.org
Cc: torvalds@linux-foundation.org, gregkh@linuxfoundation.org,
willy@infradead.org, linux-fsdevel@vger.kernel.org,
joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com,
tao.peng@linux.alibaba.com, gerry@linux.alibaba.com,
eguan@linux.alibaba.com, linux-kernel@vger.kernel.org,
luodaowen.backend@bytedance.com
Subject: [PATCH v5 21/22] erofs: implement fscache-based data readahead
Date: Wed, 16 Mar 2022 21:17:22 +0800 [thread overview]
Message-ID: <20220316131723.111553-22-jefflexu@linux.alibaba.com> (raw)
In-Reply-To: <20220316131723.111553-1-jefflexu@linux.alibaba.com>
This patch implements fscache-based data readahead. Also registers an
individual bdi for each erofs instance to enable readahead.
Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
---
fs/erofs/fscache.c | 153 +++++++++++++++++++++++++++++++++++++++++++++
fs/erofs/super.c | 4 ++
2 files changed, 157 insertions(+)
diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
index 82c52b6e077e..913ca891deb9 100644
--- a/fs/erofs/fscache.c
+++ b/fs/erofs/fscache.c
@@ -10,6 +10,13 @@ struct erofs_fscache_map {
u64 m_llen;
};
+struct erofs_fscahce_ra_ctx {
+ struct readahead_control *rac;
+ struct address_space *mapping;
+ loff_t start;
+ size_t len, done;
+};
+
static struct fscache_volume *volume;
/*
@@ -199,12 +206,158 @@ static int erofs_fscache_readpage(struct file *file, struct page *page)
return ret;
}
+static inline size_t erofs_fscache_calc_len(struct erofs_fscahce_ra_ctx *ractx,
+ struct erofs_fscache_map *fsmap)
+{
+ /*
+ * 1) For CHUNK_BASED layout, the output m_la is rounded down to the
+ * nearest chunk boundary, and the output m_llen actually starts from
+ * the start of the containing chunk.
+ * 2) For other cases, the output m_la is equal to o_la.
+ */
+ size_t len = fsmap->m_llen - (fsmap->o_la - fsmap->m_la);
+
+ return min_t(size_t, len, ractx->len - ractx->done);
+}
+
+static inline void erofs_fscache_unlock_pages(struct readahead_control *rac,
+ size_t len)
+{
+ while (len) {
+ struct page *page = readahead_page(rac);
+
+ SetPageUptodate(page);
+ unlock_page(page);
+ put_page(page);
+
+ len -= PAGE_SIZE;
+ }
+}
+
+static int erofs_fscache_ra_hole(struct erofs_fscahce_ra_ctx *ractx,
+ struct erofs_fscache_map *fsmap)
+{
+ struct iov_iter iter;
+ loff_t start = ractx->start + ractx->done;
+ size_t length = erofs_fscache_calc_len(ractx, fsmap);
+
+ iov_iter_xarray(&iter, READ, &ractx->mapping->i_pages, start, length);
+ iov_iter_zero(length, &iter);
+
+ erofs_fscache_unlock_pages(ractx->rac, length);
+ return length;
+}
+
+static int erofs_fscache_ra_noinline(struct erofs_fscahce_ra_ctx *ractx,
+ struct erofs_fscache_map *fsmap)
+{
+ struct fscache_cookie *cookie = fsmap->m_ctx->cookie;
+ loff_t start = ractx->start + ractx->done;
+ size_t length = erofs_fscache_calc_len(ractx, fsmap);
+ loff_t pstart = fsmap->m_pa + (fsmap->o_la - fsmap->m_la);
+ int ret;
+
+ ret = erofs_fscache_read_pages(cookie, ractx->mapping,
+ start, length, pstart);
+ if (!ret) {
+ erofs_fscache_unlock_pages(ractx->rac, length);
+ ret = length;
+ }
+
+ return ret;
+}
+
+static int erofs_fscache_ra_inline(struct erofs_fscahce_ra_ctx *ractx,
+ struct erofs_fscache_map *fsmap)
+{
+ struct page *page = readahead_page(ractx->rac);
+ int ret;
+
+ ret = erofs_fscache_readpage_inline(page, fsmap);
+ if (!ret) {
+ SetPageUptodate(page);
+ ret = PAGE_SIZE;
+ }
+
+ unlock_page(page);
+ put_page(page);
+ return ret;
+}
+
+static void erofs_fscache_readahead(struct readahead_control *rac)
+{
+ struct inode *inode = rac->mapping->host;
+ struct erofs_inode *vi = EROFS_I(inode);
+ struct super_block *sb = inode->i_sb;
+ struct erofs_fscahce_ra_ctx ractx;
+ int ret;
+
+ if (erofs_inode_is_data_compressed(vi->datalayout)) {
+ erofs_info(sb, "compressed layout not supported yet");
+ return;
+ }
+
+ if (!readahead_count(rac))
+ return;
+
+ ractx = (struct erofs_fscahce_ra_ctx) {
+ .rac = rac,
+ .mapping = rac->mapping,
+ .start = readahead_pos(rac),
+ .len = readahead_length(rac),
+ };
+
+ do {
+ struct erofs_map_blocks map;
+ struct erofs_fscache_map fsmap;
+
+ map.m_la = fsmap.o_la = ractx.start + ractx.done;
+
+ ret = erofs_map_blocks(inode, &map, EROFS_GET_BLOCKS_RAW);
+ if (ret)
+ return;
+
+ if (!(map.m_flags & EROFS_MAP_MAPPED)) {
+ /*
+ * Two cases will hit this:
+ * 1) EOF. Imposibble in readahead routine;
+ * 2) hole. Only CHUNK_BASED layout supports hole.
+ */
+ fsmap.m_la = map.m_la;
+ fsmap.m_llen = map.m_llen;
+ ret = erofs_fscache_ra_hole(&ractx, &fsmap);
+ continue;
+ }
+
+ ret = erofs_fscache_get_map(&fsmap, &map, sb);
+ if (ret)
+ return;
+
+ if (map.m_flags & EROFS_MAP_META) {
+ ret = erofs_fscache_ra_inline(&ractx, &fsmap);
+ continue;
+ }
+
+ switch (vi->datalayout) {
+ case EROFS_INODE_FLAT_PLAIN:
+ case EROFS_INODE_FLAT_INLINE:
+ case EROFS_INODE_CHUNK_BASED:
+ ret = erofs_fscache_ra_noinline(&ractx, &fsmap);
+ break;
+ default:
+ DBG_BUGON(1);
+ return;
+ }
+ } while (ret > 0 && ((ractx.done += ret) < ractx.len));
+}
+
static const struct address_space_operations erofs_fscache_blob_aops = {
.readpage = erofs_fscache_readpage_blob,
};
const struct address_space_operations erofs_fscache_access_aops = {
.readpage = erofs_fscache_readpage,
+ .readahead = erofs_fscache_readahead,
};
struct page *erofs_fscache_read_cache_page(struct erofs_fscache_context *ctx,
diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index f058a04a00c7..2942029a7049 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -616,6 +616,10 @@ static int erofs_fc_fill_super(struct super_block *sb, struct fs_context *fc)
return PTR_ERR(bootstrap);
sbi->bootstrap = bootstrap;
+
+ err = super_setup_bdi(sb);
+ if (err)
+ return err;
}
err = erofs_read_superblock(sb);
--
2.27.0
next prev parent reply other threads:[~2022-03-16 13:19 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 13:17 [PATCH v5 00/22] fscache,erofs: fscache-based on-demand read semantics Jeffle Xu
2022-03-16 13:17 ` [PATCH v5 01/22] fscache: export fscache_end_operation() Jeffle Xu
2022-03-16 13:17 ` [PATCH v5 02/22] cachefiles: extract write routine Jeffle Xu
2022-03-16 13:17 ` [PATCH v5 03/22] cachefiles: introduce on-demand read mode Jeffle Xu
2022-03-21 13:40 ` Matthew Wilcox
2022-03-21 14:08 ` JeffleXu
2022-03-21 14:26 ` Matthew Wilcox
2022-03-21 15:18 ` JeffleXu
2022-03-21 15:21 ` Matthew Wilcox
2022-03-21 15:30 ` David Howells
2022-03-22 17:04 ` Matthew Wilcox
2022-03-23 5:32 ` JeffleXu
2022-03-21 14:14 ` David Howells
2022-03-21 14:20 ` [Linux-cachefs] " Gao Xiang
2022-03-16 13:17 ` [PATCH v5 04/22] cachefiles: notify user daemon with anon_fd when looking up cookie Jeffle Xu
2022-03-16 19:37 ` kernel test robot
2022-03-16 13:17 ` [PATCH v5 05/22] cachefiles: notify user daemon when withdrawing cookie Jeffle Xu
2022-03-16 13:17 ` [PATCH v5 06/22] cachefiles: implement on-demand read Jeffle Xu
2022-03-16 13:17 ` [PATCH v5 07/22] cachefiles: document on-demand read mode Jeffle Xu
2022-03-16 13:17 ` [PATCH v5 08/22] erofs: use meta buffers for erofs_read_superblock() Jeffle Xu
2022-03-16 13:17 ` [PATCH v5 09/22] erofs: make erofs_map_blocks() generally available Jeffle Xu
2022-03-17 5:35 ` [Linux-cachefs] " Gao Xiang
2022-03-16 13:17 ` [PATCH v5 10/22] erofs: add mode checking helper Jeffle Xu
2022-03-17 5:36 ` [Linux-cachefs] " Gao Xiang
2022-03-18 5:26 ` JeffleXu
2022-03-16 13:17 ` [PATCH v5 11/22] erofs: register global fscache volume Jeffle Xu
2022-03-16 21:52 ` kernel test robot
2022-03-17 1:49 ` kernel test robot
2022-03-16 13:17 ` [PATCH v5 12/22] erofs: add cookie context helper functions Jeffle Xu
2022-03-16 13:17 ` [PATCH v5 13/22] erofs: add anonymous inode managing page cache of blob file Jeffle Xu
2022-03-16 13:17 ` [PATCH v5 14/22] erofs: add erofs_fscache_read_pages() helper Jeffle Xu
2022-03-16 13:17 ` [PATCH v5 15/22] erofs: register cookie context for bootstrap blob Jeffle Xu
2022-03-16 13:17 ` [PATCH v5 16/22] erofs: implement fscache-based metadata read Jeffle Xu
2022-03-16 13:17 ` [PATCH v5 17/22] erofs: implement fscache-based data read for non-inline layout Jeffle Xu
2022-03-17 6:18 ` [Linux-cachefs] " Gao Xiang
2022-03-18 5:29 ` JeffleXu
2022-03-16 13:17 ` [PATCH v5 18/22] erofs: implement fscache-based data read for inline layout Jeffle Xu
2022-03-16 13:17 ` [PATCH v5 19/22] erofs: register cookie context for data blobs Jeffle Xu
2022-03-16 13:17 ` [PATCH v5 20/22] erofs: implement fscache-based data read " Jeffle Xu
2022-03-16 13:17 ` Jeffle Xu [this message]
2022-03-17 5:22 ` [PATCH v5 21/22] erofs: implement fscache-based data readahead Gao Xiang
2022-03-18 5:41 ` JeffleXu
2022-03-16 13:17 ` [PATCH v5 22/22] erofs: add 'uuid' mount option Jeffle Xu
2022-03-21 13:34 ` [PATCH v5 03/22] cachefiles: introduce on-demand read mode David Howells
2022-03-21 14:16 ` JeffleXu
2022-03-21 14:01 ` [PATCH v5 04/22] cachefiles: notify user daemon with anon_fd when looking up cookie David Howells
2022-03-21 14:43 ` JeffleXu
2022-03-21 14:05 ` [PATCH v5 06/22] cachefiles: implement on-demand read David Howells
2022-03-21 14:51 ` JeffleXu
2022-03-21 14:20 ` [PATCH v5 05/22] cachefiles: notify user daemon when withdrawing cookie David Howells
2022-03-21 14:31 ` JeffleXu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220316131723.111553-22-jefflexu@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=bo.liu@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=dhowells@redhat.com \
--cc=eguan@linux.alibaba.com \
--cc=gerry@linux.alibaba.com \
--cc=gregkh@linuxfoundation.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luodaowen.backend@bytedance.com \
--cc=tao.peng@linux.alibaba.com \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®