From: Benjamin Li <benl@squareup.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>,
Thara Gopinath <thara.gopinath@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Zac Crosby <zac@squareup.com>, Benjamin Li <benl@squareup.com>,
Andy Gross <agross@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] thermal: thermal_of: pass-through change_mode & implement for tsens
Date: Wed, 16 Mar 2022 14:09:43 -0700 [thread overview]
Message-ID: <20220316210946.6935-1-benl@squareup.com> (raw)
Plumb through the change_mode callback from thermal core into thermal_of,
and implement change_mode for the Qualcomm tsens driver.
Supersedes "[PATCH v3] drivers: thermal: tsens: respect thermal_device_mode
in threshold irq reporting". Changelog for that patchset:
Changes in v3:
- Upgraded logging to dev_info_ratelimited and revised log message.
- Remove unrelated hunk.
Some drivers that support thermal zone disabling implement a set_mode
operation and simply disable the sensor or the relevant IRQ(s), so they
actually don't log anything when zones are disabled. These drivers are
imx_thermal.c, intel_quark_dts_thermal.c, and int3400_thermal.c.
For tsens.c, implementing a change_mode would require migrating the driver
from devm_thermal_zone_of_sensor_register to thermal_zone_device_register
(or updating thermal_of.c to add a change_mode operation in thermal_zone_
of_device_ops).
stm_thermal.c seems to use this patch's model of not disabling IRQs when
the zone is disabled (they still perform the thermal_zone_device_update
upon IRQ, but return -EAGAIN from their get_temp).
Changes in v2:
- Reordered sentences in first part of commit message to make sense.
Benjamin Li (2):
thermal: thermal_of: add pass-through change_mode to ops struct
drivers: thermal: tsens: implement change_mode to disable sensor IRQs
drivers/thermal/qcom/tsens.c | 43 ++++++++++++++++++++++++++++++++++--
drivers/thermal/qcom/tsens.h | 4 ++++
drivers/thermal/thermal_of.c | 14 ++++++++++++
include/linux/thermal.h | 2 ++
4 files changed, 61 insertions(+), 2 deletions(-)
--
2.17.1
next reply other threads:[~2022-03-16 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 21:09 Benjamin Li [this message]
2022-03-16 21:09 ` [PATCH 1/2] thermal: thermal_of: add pass-through change_mode to ops struct Benjamin Li
2022-03-16 21:09 ` [PATCH 2/2] drivers: thermal: tsens: implement change_mode to disable sensor IRQs Benjamin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220316210946.6935-1-benl@squareup.com \
--to=benl@squareup.com \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
--cc=zac@squareup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®