mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yang Li <yang.lee@linux.alibaba.com>
To: arve@android.com
Cc: tkjos@android.com, maco@android.com, joel@joelfernandes.org,
	brauner@kernel.org, hridya@google.com, surenb@google.com,
	linux-kernel@vger.kernel.org,
	Yang Li <yang.lee@linux.alibaba.com>,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: [PATCH -next] binder: Fix some kernel-doc comments
Date: Thu, 17 Mar 2022 09:40:42 +0800	[thread overview]
Message-ID: <20220317014042.126282-1-yang.lee@linux.alibaba.com> (raw)

Remove some warnings found by running scripts/kernel-doc,
which is caused by using 'make W=1'.

drivers/android/binder.c:1155: warning: expecting prototype for
binder_dec_ref(). Prototype was for binder_dec_ref_olocked() instead
drivers/android/binder.c:2683: warning: Function parameter or member
'procp' not described in 'binder_get_node_refs_for_txn'
drivers/android/binder.c:2683: warning: Excess function parameter 'proc'
description in 'binder_get_node_refs_for_txn'

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/android/binder.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 8351c5638880..65e8145e6170 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -1143,7 +1143,7 @@ static int binder_inc_ref_olocked(struct binder_ref *ref, int strong,
 }
 
 /**
- * binder_dec_ref() - dec the ref for given handle
+ * binder_dec_ref_olocked() - dec the ref for given handle
  * @ref:	ref to be decremented
  * @strong:	if true, strong decrement, else weak
  *
@@ -2658,7 +2658,7 @@ static int binder_proc_transaction(struct binder_transaction *t,
 /**
  * binder_get_node_refs_for_txn() - Get required refs on node for txn
  * @node:         struct binder_node for which to get refs
- * @proc:         returns @node->proc if valid
+ * @procp:         returns @node->proc if valid
  * @error:        if no @proc then returns BR_DEAD_REPLY
  *
  * User-space normally keeps the node alive when creating a transaction
-- 
2.20.1.7.g153144c


                 reply	other threads:[~2022-03-17  1:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220317014042.126282-1-yang.lee@linux.alibaba.com \
    --to=yang.lee@linux.alibaba.com \
    --cc=abaci@linux.alibaba.com \
    --cc=arve@android.com \
    --cc=brauner@kernel.org \
    --cc=hridya@google.com \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=surenb@google.com \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®