From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1B8FC433FE for ; Thu, 17 Mar 2022 08:07:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230443AbiCQIIk (ORCPT ); Thu, 17 Mar 2022 04:08:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbiCQIIi (ORCPT ); Thu, 17 Mar 2022 04:08:38 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 25CCE1C4B0D for ; Thu, 17 Mar 2022 01:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647504441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HhlFyUE6IEBsOcwDfZpsFqlAMN7YDfaF0SxISDC03Tg=; b=AJcZzkjA7v9V3oELPBdGubrNtaUwk/fRR5wmLvFXn/NB5b1tEbdfzb9/b8WrD5tXyP5EYC mN6mR6TGqHu8Q+yNl59bFfetJ5t+gjWXvNKhrk7gMLeGDZ2gPIpEW3LpfpUDC/zUdmNo7Q GyM5uQ3ICuC3E3q6R85Qpd29YEzr2j8= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-475-bA16tz9JPfG1CeLHdG6H-w-1; Thu, 17 Mar 2022 04:07:19 -0400 X-MC-Unique: bA16tz9JPfG1CeLHdG6H-w-1 Received: by mail-qt1-f197.google.com with SMTP id bq21-20020a05622a1c1500b002e06d6279d5so3029680qtb.7 for ; Thu, 17 Mar 2022 01:07:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HhlFyUE6IEBsOcwDfZpsFqlAMN7YDfaF0SxISDC03Tg=; b=z03MoOliJ3pzua9Q8I4dK+b/p79xPH7/EjYApsZjpHZqwaZ/e+m0pafF8RVnh9zDb+ QK7jkcODHrfvUFY/9wqb22S1PvEZ/IOIwYu1vbvNbwN01pnSw94cOlYP2tC/SErxzIg/ ur3Jdn+gjUCI5m79aCxPg7ws1IsF4zkaJj9WFOOOMuoF/eb999L2LPe5GrhrcO/Ga6Gz ZJ1gjVgaubd1lDHZ9QLOp/7ezU6AR1ITdgirWZxTB98+pf7onih+JUUlRRfsy4t2ElYM KYNHdkY3fEZO78UE7SN3WEvLPfBdBmDBu3qbY/MAXAZTETwBHfp9qX9BXe9p6udb4Zsf azkg== X-Gm-Message-State: AOAM531U8xBcl1QW/WSR5MX74EF76a3OObwitiOBi01OAvZger5PYED/ T+z3ihMAsRJyxGbCyTkl3SgOejhTMEkkUd9U3ZxgL1w9aiU3Gpg9iY0y8i5wY/C2FRX+2z2Xr6y 5Fn82bD0UJi2kqfqKfwW/DHo5 X-Received: by 2002:a05:622a:164d:b0:2e1:d592:ade2 with SMTP id y13-20020a05622a164d00b002e1d592ade2mr2739620qtj.602.1647504439394; Thu, 17 Mar 2022 01:07:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3SA57vAbApSbgd6VxWAFzL+Wipmtr+x6XIq8uK0YzNcWOmMeuA4rjFzXIwSc3fKrbvcggGQ== X-Received: by 2002:a05:622a:164d:b0:2e1:d592:ade2 with SMTP id y13-20020a05622a164d00b002e1d592ade2mr2739609qtj.602.1647504439118; Thu, 17 Mar 2022 01:07:19 -0700 (PDT) Received: from sgarzare-redhat (host-79-42-202-12.retail.telecomitalia.it. [79.42.202.12]) by smtp.gmail.com with ESMTPSA id j11-20020a37a00b000000b0067b436faccesm2040526qke.122.2022.03.17.01.07.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 01:07:18 -0700 (PDT) Date: Thu, 17 Mar 2022 09:07:08 +0100 From: Stefano Garzarella To: Krasnov Arseniy Vladimirovich Cc: Krasnov Arseniy , Rokosov Dmitry Dmitrievich , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next v3 1/2] af_vsock: SOCK_SEQPACKET receive timeout test Message-ID: <20220317080708.duovh4tnf6oxhciq@sgarzare-redhat> References: <4ecfa306-a374-93f6-4e66-be62895ae4f7@sberdevices.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 17, 2022 at 05:26:45AM +0000, Krasnov Arseniy Vladimirovich wrote: >Test for receive timeout check: connection is established, >receiver sets timeout, but sender does nothing. Receiver's >'read()' call must return EAGAIN. > >Signed-off-by: Krasnov Arseniy Vladimirovich >--- > v2 -> v3: > 1) Use 'fprintf()' instead of 'perror()' where 'errno' variable > is not affected. > 2) Print 'read()' overhead. > > tools/testing/vsock/vsock_test.c | 84 ++++++++++++++++++++++++++++++++ > 1 file changed, 84 insertions(+) > >diff --git a/tools/testing/vsock/vsock_test.c b/tools/testing/vsock/vsock_test.c >index 2a3638c0a008..f5498de6751d 100644 >--- a/tools/testing/vsock/vsock_test.c >+++ b/tools/testing/vsock/vsock_test.c >@@ -16,6 +16,7 @@ > #include > #include > #include >+#include > > #include "timeout.h" > #include "control.h" >@@ -391,6 +392,84 @@ static void test_seqpacket_msg_trunc_server(const struct test_opts *opts) > close(fd); > } > >+static time_t current_nsec(void) >+{ >+ struct timespec ts; >+ >+ if (clock_gettime(CLOCK_REALTIME, &ts)) { >+ perror("clock_gettime(3) failed"); >+ exit(EXIT_FAILURE); >+ } >+ >+ return (ts.tv_sec * 1000000000ULL) + ts.tv_nsec; >+} >+ >+#define RCVTIMEO_TIMEOUT_SEC 1 >+#define READ_OVERHEAD_NSEC 250000000 /* 0.25 sec */ >+ >+static void test_seqpacket_timeout_client(const struct test_opts *opts) >+{ >+ int fd; >+ struct timeval tv; >+ char dummy; >+ time_t read_enter_ns; >+ time_t read_overhead_ns; >+ >+ fd = vsock_seqpacket_connect(opts->peer_cid, 1234); >+ if (fd < 0) { >+ perror("connect"); >+ exit(EXIT_FAILURE); >+ } >+ >+ tv.tv_sec = RCVTIMEO_TIMEOUT_SEC; >+ tv.tv_usec = 0; >+ >+ if (setsockopt(fd, SOL_SOCKET, SO_RCVTIMEO, (void *)&tv, sizeof(tv)) == -1) { >+ perror("setsockopt 'SO_RCVTIMEO'"); >+ exit(EXIT_FAILURE); >+ } >+ >+ read_enter_ns = current_nsec(); >+ >+ if (errno != EAGAIN) { >+ perror("EAGAIN expected"); >+ exit(EXIT_FAILURE); >+ } Should this check go after read()? Indeed now the test fails on my environment with "EAGAIN expected" message. The rest LGTM :-) Stefano >+ >+ if (read(fd, &dummy, sizeof(dummy)) != -1) { >+ fprintf(stderr, >+ "expected 'dummy' read(2) failure\n"); >+ exit(EXIT_FAILURE); >+ } >+ >+ read_overhead_ns = current_nsec() - read_enter_ns - >+ 1000000000ULL * RCVTIMEO_TIMEOUT_SEC; >+ >+ if (read_overhead_ns > READ_OVERHEAD_NSEC) { >+ fprintf(stderr, >+ "too much time in read(2), %lu > %i ns\n", >+ read_overhead_ns, READ_OVERHEAD_NSEC); >+ exit(EXIT_FAILURE); >+ } >+ >+ control_writeln("WAITDONE"); >+ close(fd); >+} >+ >+static void test_seqpacket_timeout_server(const struct test_opts *opts) >+{ >+ int fd; >+ >+ fd = vsock_seqpacket_accept(VMADDR_CID_ANY, 1234, NULL); >+ if (fd < 0) { >+ perror("accept"); >+ exit(EXIT_FAILURE); >+ } >+ >+ control_expectln("WAITDONE"); >+ close(fd); >+} >+ > static struct test_case test_cases[] = { > { > .name = "SOCK_STREAM connection reset", >@@ -431,6 +510,11 @@ static struct test_case test_cases[] = { > .run_client = test_seqpacket_msg_trunc_client, > .run_server = test_seqpacket_msg_trunc_server, > }, >+ { >+ .name = "SOCK_SEQPACKET timeout", >+ .run_client = test_seqpacket_timeout_client, >+ .run_server = test_seqpacket_timeout_server, >+ }, > {}, > }; > >-- >2.25.1