Re: [PATCH v14 6/6] soc: mediatek: mutex: add functions that operate registers by CMDQ

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

From: Miles Chen <miles.chen@mediatek.com>
To: <moudy.ho@mediatek.com>
Cc: <Project_Global_Chrome_Upstream_Group@mediatek.com>,
	<acourbot@chromium.org>, <allen-kh.cheng@mediatek.com>,
	<angelogioacchino.delregno@collabora.com>,
	<chunkuang.hu@kernel.org>, <daoyuan.huang@mediatek.com>,
	<devicetree@vger.kernel.org>, <drinkcat@chromium.org>,
	<geert+renesas@glider.be>, <hsinyi@google.com>,
	<hverkuil-cisco@xs4all.nl>, <jason-jh.lin@mediatek.com>,
	<jernej.skrabec@siol.net>, <laurent.pinchart@ideasonboard.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	<maoguang.meng@mediatek.com>, <matthias.bgg@gmail.com>,
	<mchehab@kernel.org>, <menghui.lin@mediatek.com>,
	<miles.chen@mediatek.com>, <pihsun@chromium.org>,
	<ping-hsun.wu@mediatek.com>, <randy.wu@mediatek.com>,
	<river.cheng@mediatek.com>, <rob@landley.net>,
	<robh+dt@kernel.org>, <roy-cw.yeh@mediatek.com>,
	<sj.huang@mediatek.com>, <srv_heupstream@mediatek.com>,
	<tfiga@chromium.org>
Subject: Re: [PATCH v14 6/6] soc: mediatek: mutex: add functions that operate registers by CMDQ
Date: Fri, 18 Mar 2022 16:38:44 +0800	[thread overview]
Message-ID: <20220318083844.24859-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <72f7feabe22064365457b5b72dfb1972ba2b3151.camel@mediatek.com>

Hi Moudy,

>> >  		}
>> >  	}
>> >  
>> > +	if (of_address_to_resource(dev->of_node, 0, &addr) < 0)
>> > +		mtx->addr = 0L;
>> 
>> addr is phys_addr_t, which means that it holds a physical address.
>> 0 may be a valid address in some platforms, so I think
>> we should not set mtx->addr = 0L when of_address_to_resource fails.
>> Maybe probe fail by returning dev_err_probe()?
>> 
>> Thanks,
>> Miles
>
>Hi Miles,
>
>This does lead to the situation you mentioned, and sorry for the
>deficient dts parsing flow. Maybe we should follow "gce-client" usage
>and add a check condition when needed to avoid compatibility issues?
>
>Thanks,
>Moudy

According to Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.yaml,
it is required to have a reg field in the mutex node. So I think we can
fail in this case.

Thanks,
Miles

next      parent reply	other threads:[~2022-03-18  8:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <72f7feabe22064365457b5b72dfb1972ba2b3151.camel@mediatek.com>
2022-03-18  8:38 ` Miles Chen [this message]
2022-04-11  7:23 [PATCH v14 0/6] Add mutex support for MDP Moudy Ho
2022-04-11  7:24 ` [PATCH v14 6/6] soc: mediatek: mutex: add functions that operate registers by CMDQ Moudy Ho
2022-04-13  8:41   ` AngeloGioacchino Del Regno
  -- strict thread matches above, loose matches on Subject: below --
2022-03-17 14:39 [PATCH v14 0/6] Add mutex support for MDP Moudy Ho
2022-03-17 14:39 ` [PATCH v14 6/6] soc: mediatek: mutex: add functions that operate registers by CMDQ Moudy Ho
2022-03-17 23:31   ` Miles Chen
2022-03-22 10:04   ` CK Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220318083844.24859-1-miles.chen@mediatek.com \
    --to=miles.chen@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=acourbot@chromium.org \
    --cc=allen-kh.cheng@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=daoyuan.huang@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=geert+renesas@glider.be \
    --cc=hsinyi@google.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=jason-jh.lin@mediatek.com \
    --cc=jernej.skrabec@siol.net \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=maoguang.meng@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=menghui.lin@mediatek.com \
    --cc=moudy.ho@mediatek.com \
    --cc=pihsun@chromium.org \
    --cc=ping-hsun.wu@mediatek.com \
    --cc=randy.wu@mediatek.com \
    --cc=river.cheng@mediatek.com \
    --cc=rob@landley.net \
    --cc=robh+dt@kernel.org \
    --cc=roy-cw.yeh@mediatek.com \
    --cc=sj.huang@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®