From: Steven Rostedt <rostedt@goodmis.org>
To: Wolfram Sang <wsa@kernel.org>
Cc: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>,
Ingo Molnar <mingo@redhat.com>,
Jamie Iles <quic_jiles@quicinc.com>,
Graeme Gregory <quic_ggregory@quicinc.com>,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2] i2c: add tracepoints for I2C slave events
Date: Fri, 18 Mar 2022 09:58:17 -0400 [thread overview]
Message-ID: <20220318095817.4ad3a65a@gandalf.local.home> (raw)
In-Reply-To: <YjRkvPc9uahbozbQ@shikoro>
On Fri, 18 Mar 2022 11:53:48 +0100
Wolfram Sang <wsa@kernel.org> wrote:
> > trace printings can be selected by adding a filter like:
> >
> > echo adapter_nr==1 >/sys/kernel/tracing/events/i2c_slave/filter
> >
> > Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
>
> Steven, are you happy with the tracepoint parts of this patch?
Strange. I do not have v2 in my inbox anywhere. I checked the spam folders
and found nothing. I had a glitch in my mail server around this time and
maybe it was dropped then.
Let me take a look at it in my LMKL folder, which it appears to be there :-/
-- Steve
>
>
> > + if (trace_i2c_slave_enabled() && !ret)
> > + trace_i2c_slave(client, event, val);
>
> Why '!ret'? I think we should always print 'ret' in the trace as well.
> Backends are allowed to send errnos on WRITE_RECEIVED to NACK the
> reception of a byte. This is useful information, too, or?
>
> Rest looks good to me.
>
> Thanks,
>
> Wolfram
>
next prev parent reply other threads:[~2022-03-18 13:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 16:33 Jae Hyun Yoo
2022-03-18 10:53 ` Wolfram Sang
2022-03-18 13:58 ` Steven Rostedt [this message]
2022-03-18 14:09 ` Jae Hyun Yoo
2022-03-18 14:02 ` Steven Rostedt
2022-03-18 14:14 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318095817.4ad3a65a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=quic_ggregory@quicinc.com \
--cc=quic_jaehyoo@quicinc.com \
--cc=quic_jiles@quicinc.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®