mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Morse <james.morse@arm.com>
To: stable@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, james.morse@arm.com,
	catalin.marinas@arm.com
Subject: [stable:PATCH v4.19.235 11/22] arm64: entry: Make the kpti trampoline's kpti sequence optional
Date: Fri, 18 Mar 2022 17:48:31 +0000	[thread overview]
Message-ID: <20220318174842.2321061-12-james.morse@arm.com> (raw)
In-Reply-To: <20220318174842.2321061-1-james.morse@arm.com>

commit c47e4d04ba0f1ea17353d85d45f611277507e07a upstream.

Spectre-BHB needs to add sequences to the vectors. Having one global
set of vectors is a problem for big/little systems where the sequence
is costly on cpus that are not vulnerable.

Making the vectors per-cpu in the style of KVM's bh_harden_hyp_vecs
requires the vectors to be generated by macros.

Make the kpti re-mapping of the kernel optional, so the macros can be
used without kpti.

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: James Morse <james.morse@arm.com>
---
 arch/arm64/kernel/entry.S | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
index 03c45538a93f..50843161607e 100644
--- a/arch/arm64/kernel/entry.S
+++ b/arch/arm64/kernel/entry.S
@@ -970,9 +970,10 @@ alternative_else_nop_endif
 	sub	\dst, \dst, PAGE_SIZE
 	.endm
 
-	.macro tramp_ventry, vector_start, regsize
+	.macro tramp_ventry, vector_start, regsize, kpti
 	.align	7
 1:
+	.if	\kpti == 1
 	.if	\regsize == 64
 	msr	tpidrro_el0, x30	// Restored in kernel_ventry
 	.endif
@@ -994,8 +995,12 @@ alternative_insn isb, nop, ARM64_WORKAROUND_QCOM_FALKOR_E1003
 #endif
 	prfm	plil1strm, [x30, #(1b - \vector_start)]
 	msr	vbar_el1, x30
+	isb
+	.else
+	ldr	x30, =vectors
+	.endif // \kpti == 1
+
 	add	x30, x30, #(1b - \vector_start + 4)
-	isb
 	ret
 .org 1b + 128	// Did we overflow the ventry slot?
 	.endm
@@ -1012,15 +1017,15 @@ alternative_insn isb, nop, ARM64_WORKAROUND_QCOM_FALKOR_E1003
 	eret
 	.endm
 
-	.macro	generate_tramp_vector
+	.macro	generate_tramp_vector,	kpti
 .Lvector_start\@:
 	.space	0x400
 
 	.rept	4
-	tramp_ventry	.Lvector_start\@, 64
+	tramp_ventry	.Lvector_start\@, 64, \kpti
 	.endr
 	.rept	4
-	tramp_ventry	.Lvector_start\@, 32
+	tramp_ventry	.Lvector_start\@, 32, \kpti
 	.endr
 	.endm
 
@@ -1031,7 +1036,7 @@ alternative_insn isb, nop, ARM64_WORKAROUND_QCOM_FALKOR_E1003
 	.pushsection ".entry.tramp.text", "ax"
 	.align	11
 ENTRY(tramp_vectors)
-	generate_tramp_vector
+	generate_tramp_vector	kpti=1
 END(tramp_vectors)
 
 ENTRY(tramp_exit_native)
-- 
2.30.2


  parent reply	other threads:[~2022-03-18 17:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18 17:48 [stable:PATCH v4.19.235 00/22] arm64: Mitigate spectre style branch history side channels James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 01/22] arm64: Add part number for Arm Cortex-A77 James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 02/22] arm64: Add Neoverse-N2, Cortex-A710 CPU part definition James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 03/22] arm64: Add Cortex-X2 " James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 04/22] arm64: entry.S: Add ventry overflow sanity checks James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 05/22] arm64: entry: Make the trampoline cleanup optional James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 06/22] arm64: entry: Free up another register on kpti's tramp_exit path James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 07/22] arm64: entry: Move the trampoline data page before the text page James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 08/22] arm64: entry: Allow tramp_alias to access symbols after the 4K boundary James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 09/22] arm64: entry: Don't assume tramp_vectors is the start of the vectors James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 10/22] arm64: entry: Move trampoline macros out of ifdef'd section James Morse
2022-03-18 17:48 ` James Morse [this message]
2022-03-18 17:48 ` [stable:PATCH v4.19.235 12/22] arm64: entry: Allow the trampoline text to occupy multiple pages James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 13/22] arm64: entry: Add non-kpti __bp_harden_el1_vectors for mitigations James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 14/22] arm64: entry: Add vectors that have the bhb mitigation sequences James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 15/22] arm64: entry: Add macro for reading symbol addresses from the trampoline James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 16/22] arm64: Add percpu vectors for EL1 James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 17/22] arm64: proton-pack: Report Spectre-BHB vulnerabilities as part of Spectre-v2 James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 18/22] KVM: arm64: Add templates for BHB mitigation sequences James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 19/22] arm64: Mitigate spectre style branch history side channels James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 20/22] KVM: arm64: Allow SMCCC_ARCH_WORKAROUND_3 to be discovered and migrated James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 21/22] arm64: add ID_AA64ISAR2_EL1 sys register James Morse
2022-03-18 17:48 ` [stable:PATCH v4.19.235 22/22] arm64: Use the clearbhb instruction in mitigations James Morse
2022-03-19 12:52 ` [stable:PATCH v4.19.235 00/22] arm64: Mitigate spectre style branch history side channels Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220318174842.2321061-12-james.morse@arm.com \
    --to=james.morse@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®