From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA3B5C433EF for ; Fri, 18 Mar 2022 21:20:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241102AbiCRVWQ (ORCPT ); Fri, 18 Mar 2022 17:22:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239608AbiCRVWL (ORCPT ); Fri, 18 Mar 2022 17:22:11 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8880F2EDC10 for ; Fri, 18 Mar 2022 14:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647638452; x=1679174452; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9sairRXfvoFNPw41qAvdDDcBedxdFmPoTsHOP2kTm18=; b=jkLBiUllvv5o44ZXxJgDEIHprT3B71cQsrTmqYkuMtkYwZDAMGAyj55c 7oUERPd+ZrPIDPFF+v2Wug6mPZUuPirWjqsg3/419xre7Dbip1lEsmlAE 3gkIkjygc4OKWcL+F6hQiDWzOcV38EmO/iuHpPem71DLbABFtTCA+3e82 708+og30GuIaNt4MEU2skPI8LuZjQhcLilQl3FS4bBqYUVzxUBg/veEZG P/2IfGj0hYZPNKkTXU4ljQ4PEBeGdvlAYJcTaopodcFW4qk0Oo1TlN/Cq j/Y9xdkw10NqlKOdEvgyl8BPe3BKLmNoDlJQbMtlRWCpFo5DAcIPER9Pa A==; X-IronPort-AV: E=McAfee;i="6200,9189,10290"; a="343667515" X-IronPort-AV: E=Sophos;i="5.90,192,1643702400"; d="scan'208";a="343667515" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2022 14:20:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,192,1643702400"; d="scan'208";a="499393890" Received: from lkp-server02.sh.intel.com (HELO 89b41b6ae01c) ([10.239.97.151]) by orsmga003.jf.intel.com with ESMTP; 18 Mar 2022 14:20:49 -0700 Received: from kbuild by 89b41b6ae01c with local (Exim 4.92) (envelope-from ) id 1nVK1g-000FAU-T8; Fri, 18 Mar 2022 21:20:48 +0000 Date: Sat, 19 Mar 2022 05:20:16 +0800 From: kernel test robot To: Jonathan Lassoff , OGAWA Hirofumi Cc: kbuild-all@lists.01.org, Andrew Morton , Linux Memory Management List , linux-kernel@vger.kernel.org, Jonathan Lassoff Subject: Re: [PATCH v2] Add FAT messages to printk index Message-ID: <202203190531.boviZgnl-lkp@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jonathan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hnaz-mm/master] [also build test WARNING on linux/master linus/master v5.17-rc8 next-20220318] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jonathan-Lassoff/Add-FAT-messages-to-printk-index/20220319-012711 base: https://github.com/hnaz/linux-mm master config: m68k-defconfig (https://download.01.org/0day-ci/archive/20220319/202203190531.boviZgnl-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/e3f2c52ef480a29ed0b693801bcd9497c19b89ab git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jonathan-Lassoff/Add-FAT-messages-to-printk-index/20220319-012711 git checkout e3f2c52ef480a29ed0b693801bcd9497c19b89ab # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash fs/fat/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): fs/fat/misc.c:49: warning: Function parameter or member 'sb' not described in '_fat_msg' fs/fat/misc.c:49: warning: Function parameter or member 'level' not described in '_fat_msg' fs/fat/misc.c:49: warning: Function parameter or member 'fmt' not described in '_fat_msg' >> fs/fat/misc.c:49: warning: expecting prototype for fat_msg(). Prototype was for _fat_msg() instead vim +49 fs/fat/misc.c ^1da177e4c3f415 Linus Torvalds 2005-04-16 43 81ac21d34a91e85 Oleksij Rempel 2011-04-12 44 /** 81ac21d34a91e85 Oleksij Rempel 2011-04-12 45 * fat_msg() - print preformated FAT specific messages. Every thing what is 81ac21d34a91e85 Oleksij Rempel 2011-04-12 46 * not fat_fs_error() should be fat_msg(). 81ac21d34a91e85 Oleksij Rempel 2011-04-12 47 */ e3f2c52ef480a29 Jonathan Lassoff 2022-03-18 48 void _fat_msg(struct super_block *sb, const char *level, const char *fmt, ...) 81ac21d34a91e85 Oleksij Rempel 2011-04-12 @49 { 81ac21d34a91e85 Oleksij Rempel 2011-04-12 50 struct va_format vaf; 81ac21d34a91e85 Oleksij Rempel 2011-04-12 51 va_list args; 81ac21d34a91e85 Oleksij Rempel 2011-04-12 52 81ac21d34a91e85 Oleksij Rempel 2011-04-12 53 va_start(args, fmt); 81ac21d34a91e85 Oleksij Rempel 2011-04-12 54 vaf.fmt = fmt; 81ac21d34a91e85 Oleksij Rempel 2011-04-12 55 vaf.va = &args; e3f2c52ef480a29 Jonathan Lassoff 2022-03-18 56 _printk(FAT_PRINTK_PREFIX "%pV\n", level, sb->s_id, &vaf); 81ac21d34a91e85 Oleksij Rempel 2011-04-12 57 va_end(args); 81ac21d34a91e85 Oleksij Rempel 2011-04-12 58 } 81ac21d34a91e85 Oleksij Rempel 2011-04-12 59 --- 0-DAY CI Kernel Test Service https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org