From: Florian Westphal <fw@strlen.de>
To: zhouzhouyi@gmail.com
Cc: edumazet@google.com, davem@davemloft.net,
yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Wei Xu <xuweihf@ustc.edu.cn>
Subject: Re: [PATCH] net:ipv4: send an ack when seg.ack > snd.nxt
Date: Sat, 19 Mar 2022 11:04:43 +0100 [thread overview]
Message-ID: <20220319100443.GA13956@breakpoint.cc> (raw)
In-Reply-To: <20220319090142.137998-1-zhouzhouyi@gmail.com>
zhouzhouyi@gmail.com <zhouzhouyi@gmail.com> wrote:
> - if (after(ack, tp->snd_nxt))
> + if (after(ack, tp->snd_nxt)) {
> + tcp_send_ack(sk);
> return -1;
> + }
If we really need to do this we need to
if (!(flag & FLAG_NO_CHALLENGE_ACK))
tcp_send_challenge_ack(sk);
... else this might result in two acks?
Whats the problem thats being fixed here?
next prev parent reply other threads:[~2022-03-19 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 9:01 zhouzhouyi
2022-03-19 10:04 ` Florian Westphal [this message]
2022-03-19 10:34 ` Zhouyi Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220319100443.GA13956@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xuweihf@ustc.edu.cn \
--cc=yoshfuji@linux-ipv6.org \
--cc=zhouzhouyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®