From: Xiaomeng Tong <xiam0nd.tong@gmail.com>
To: jakobkoschel@gmail.com
Cc: alim.akhtar@samsung.com, avri.altman@wdc.com, beanhuo@micron.com,
bvanassche@acm.org, daejun7.park@samsung.com, jejb@linux.ibm.com,
keosung.park@samsung.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
xiam0nd.tong@gmail.com
Subject: Re: [PATCH] ufs: remove an unneed NULL check on list iterator
Date: Sun, 20 Mar 2022 12:57:34 +0800 [thread overview]
Message-ID: <20220320045734.14087-1-xiam0nd.tong@gmail.com> (raw)
In-Reply-To: <6EEE0ACC-6F7F-4D29-AA2B-751E4677B35E@gmail.com>
On Sun, 20 Mar 2022 01:57:39 +0100, Jakob Koschel <jakobkoschel@gmail.com> wrote:
> Maybe it make more sense to move that check after the loop body instead
> of removing it completely? This code obviously does nothing in it's current
> state but it's clear what the original intention was, so restoring that would
> perhaps be better.
>
> But probably someone with more experience about this code can make the call
>
This seems like a better choice, if it doesn't go against the author's original
intention. I will fix it in PATCH v2, thanks.
--
Xiaomeng Tong
prev parent reply other threads:[~2022-03-20 4:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 4:26 Xiaomeng Tong
2022-03-20 0:57 ` Jakob Koschel
2022-03-20 4:57 ` Xiaomeng Tong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220320045734.14087-1-xiam0nd.tong@gmail.com \
--to=xiam0nd.tong@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=daejun7.park@samsung.com \
--cc=jakobkoschel@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=keosung.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®