From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DBB4C433EF for ; Mon, 21 Mar 2022 12:15:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347239AbiCUMQb (ORCPT ); Mon, 21 Mar 2022 08:16:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240603AbiCUMQa (ORCPT ); Mon, 21 Mar 2022 08:16:30 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE7C3A6E09 for ; Mon, 21 Mar 2022 05:15:04 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 22LCEupe043704; Mon, 21 Mar 2022 07:14:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1647864896; bh=BNk4Jc1KDk892pR+9LlcEhmjDAUnom/cqNmHxG2VCrA=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=bhQLiQ9ifonNed+S6fsAAAETZ14ItgsxW/zx2mzOcNFeGepLFEF/t3ei1UJE6GhKP Fg8F7Lpn3QmEiPq0fD2eSK1PFY8okikyk1xguNGSiGZywz2TYDzqL6DnkZNaTIX4Jk T5dghXXn+WXa/PtVs03CSvTzNfU94ZQ8Do8jts1M= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 22LCEuQ6108888 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 21 Mar 2022 07:14:56 -0500 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Mon, 21 Mar 2022 07:14:56 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Mon, 21 Mar 2022 07:14:56 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 22LCEt9s028012; Mon, 21 Mar 2022 07:14:56 -0500 Date: Mon, 21 Mar 2022 17:44:55 +0530 From: Pratyush Yadav To: Tudor Ambarus CC: , , , , , , Subject: Re: [PATCH v2 3/8] mtd: spi-nor: core: Use auto-detection only once Message-ID: <20220321121455.bpql7x4ebhq7s36l@ti.com> References: <20220228111712.111737-1-tudor.ambarus@microchip.com> <20220228111712.111737-4-tudor.ambarus@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220228111712.111737-4-tudor.ambarus@microchip.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/02/22 01:17PM, Tudor Ambarus wrote: > In case spi_nor_match_name() returned NULL, the auto detection was > issued twice. There's no reason to try to detect the same chip twice, > do the auto detection only once. > > Signed-off-by: Tudor Ambarus > --- > drivers/mtd/spi-nor/core.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > index f87cb7d3daab..b1d6fa65417d 100644 > --- a/drivers/mtd/spi-nor/core.c > +++ b/drivers/mtd/spi-nor/core.c > @@ -2894,13 +2894,15 @@ static const struct flash_info *spi_nor_match_name(struct spi_nor *nor, > static const struct flash_info *spi_nor_get_flash_info(struct spi_nor *nor, > const char *name) > { > - const struct flash_info *info = NULL; > + const struct flash_info *info = NULL, *detected_info = NULL; > > if (name) > info = spi_nor_match_name(nor, name); > /* Try to auto-detect if chip name wasn't specified or not found */ > - if (!info) > - info = spi_nor_read_id(nor); > + if (!info) { > + detected_info = spi_nor_read_id(nor); > + info = detected_info; > + } > if (IS_ERR_OR_NULL(info)) > return ERR_PTR(-ENOENT); > > @@ -2908,7 +2910,7 @@ static const struct flash_info *spi_nor_get_flash_info(struct spi_nor *nor, > * If caller has specified name of flash model that can normally be > * detected using JEDEC, let's verify it. > */ > - if (name && info->id_len) { > + if (name && !detected_info && info->id_len) { > const struct flash_info *jinfo; > > jinfo = spi_nor_read_id(nor); I think the flow can be a little bit better. How about: if (name) info = spi_nor_match_name(); if (!info) { info = spi_nor_read_id(); if (IS_ERR_OR_NULL(info)) return ERR_PTR(-ENOENT); return info; } if (name && info->id_len) { ... } -- Regards, Pratyush Yadav Texas Instruments Inc.