From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C15AC433F5 for ; Mon, 21 Mar 2022 12:34:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347371AbiCUMgQ (ORCPT ); Mon, 21 Mar 2022 08:36:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347066AbiCUMgO (ORCPT ); Mon, 21 Mar 2022 08:36:14 -0400 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AE0619C1B for ; Mon, 21 Mar 2022 05:34:49 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 22LCYgRG082999; Mon, 21 Mar 2022 07:34:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1647866082; bh=/FSvcrz0QymIRCi6RH71gwTjqKsvMqVR1lnXAd9SB4E=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=Im7k/IiXxRtqScsM9BWgoSnBTBm29KR8Cqm/ORmxH9GCx/2rdh7+TX3qG6ujSoc0P bklvB0xKPS9cbndfrAAm4hU98hE8PAOKn5TiLkarmqQP3RBjslJHLSKTK/nDPNwhWC qAd1RmaK+3gHEQaTP5dJpPuelPOK7aNPm2A7zPwc= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 22LCYgDE005898 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 21 Mar 2022 07:34:42 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Mon, 21 Mar 2022 07:34:41 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Mon, 21 Mar 2022 07:34:41 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 22LCYf2i082341; Mon, 21 Mar 2022 07:34:41 -0500 Date: Mon, 21 Mar 2022 18:04:40 +0530 From: Pratyush Yadav To: Tudor Ambarus CC: , , , , , , Subject: Re: [PATCH v2 8/8] mtd: spi-nor: spansion: Rework spi_nor_cypress_octal_dtr_enable() Message-ID: <20220321123440.prhhkzvgvgao2fqr@ti.com> References: <20220228111712.111737-1-tudor.ambarus@microchip.com> <20220228111712.111737-9-tudor.ambarus@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220228111712.111737-9-tudor.ambarus@microchip.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/02/22 01:17PM, Tudor Ambarus wrote: > Introduce template operation to remove code duplication. > Split spi_nor_cypress_octal_dtr_enable() in > spi_nor_cypress_octal_dtr_ena() spi_nor_cypress_octal_dtr_dis() as it no > longer made sense to try to keep everything alltogether: too many > "if (enable)" throughout the code, which made the code difficult to read. > > Signed-off-by: Tudor Ambarus Reviewed-by: Pratyush Yadav Will send my tested-by separately once I get a chance to test this. -- Regards, Pratyush Yadav Texas Instruments Inc.