From: Jagath Jog J <jagathjog1996@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Dan Robertson <dan@dlrobertson.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/5] iio: accel: bma400: conversion to device-managed function
Date: Tue, 22 Mar 2022 02:50:13 +0530 [thread overview]
Message-ID: <20220321212012.GB10058@jagath-PC> (raw)
In-Reply-To: <CAHp75Vem7DS1oXRt=d78pKe4WEWVOJ7uR8p9r33H5Ws9Rz4Qmg@mail.gmail.com>
Hello Andy,
On Mon, Mar 21, 2022 at 10:30:26AM +0200, Andy Shevchenko wrote:
> On Sat, Mar 19, 2022 at 8:10 PM Jagath Jog J <jagathjog1996@gmail.com> wrote:
> >
> > This is a conversion to device-managed by using devm_iio_device_register
> > inside probe function, now disabling the regulator and putting bma400 to
> > power down via a devm_add_action_or_reset() hook.
> >
> > The dev_set_drvdata() call, bma400_remove() function and hooks in the I2C
> > and SPI driver struct is removed as devm_iio_device_register function is
> > used to automatically unregister on driver detach.
>
> ...
>
> > +static void bma400_disable(void *data_ptr)
> > +{
> > + struct bma400_data *data = data_ptr;
> > + int ret;
>
> > + ret = bma400_set_power_mode(data, POWER_MODE_SLEEP);
> > + if (ret)
> > + dev_warn(data->dev, "Failed to put device into sleep mode (%pe)\n",
> > + ERR_PTR(ret));
>
> By what reason did you remove mutex around this call?
>
> > + regulator_bulk_disable(ARRAY_SIZE(data->regulators), data->regulators);
> > +}
Sorry my mistake, I missed this.
I will include the mutex calls in next patch version.
>
>
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2022-03-21 21:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 18:10 [PATCH v1 0/5] iio: accel: bma400: Add support for buffer and step Jagath Jog J
2022-03-19 18:10 ` [PATCH v1 1/5] iio: accel: bma400: conversion to device-managed function Jagath Jog J
2022-03-20 17:14 ` Jonathan Cameron
2022-03-21 21:12 ` Jagath Jog J
2022-03-22 20:41 ` Jonathan Cameron
2022-03-21 8:30 ` Andy Shevchenko
2022-03-21 21:20 ` Jagath Jog J [this message]
2022-03-19 18:10 ` [PATCH v1 2/5] iio: accel: bma400: changing scale min and max macro values Jagath Jog J
2022-03-20 17:17 ` Jonathan Cameron
2022-03-19 18:10 ` [PATCH v1 3/5] iio: accel: bma400: Add triggered buffer support Jagath Jog J
2022-03-20 3:30 ` kernel test robot
2022-03-20 17:26 ` Jonathan Cameron
2022-03-21 8:39 ` Andy Shevchenko
2022-03-21 22:21 ` Jagath Jog J
2022-03-22 8:54 ` Andy Shevchenko
2022-03-22 15:40 ` Jagath Jog J
2022-03-22 16:12 ` Andy Shevchenko
2022-03-19 18:10 ` [PATCH v1 4/5] iio: accel: bma400: Add separate channel for step counter Jagath Jog J
2022-03-20 17:30 ` Jonathan Cameron
2022-03-21 8:42 ` Andy Shevchenko
2022-03-21 8:43 ` Andy Shevchenko
2022-03-19 18:10 ` [PATCH v1 5/5] iio: accel: bma400: Add step change event Jagath Jog J
2022-03-20 17:37 ` Jonathan Cameron
2022-03-21 22:52 ` Jagath Jog J
2022-03-21 8:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220321212012.GB10058@jagath-PC \
--to=jagathjog1996@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=dan@dlrobertson.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®