From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8BE4C433FE for ; Tue, 22 Mar 2022 06:20:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236931AbiCVGVd (ORCPT ); Tue, 22 Mar 2022 02:21:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236853AbiCVGVb (ORCPT ); Tue, 22 Mar 2022 02:21:31 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DD38BC89; Mon, 21 Mar 2022 23:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1647930004; x=1679466004; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fuupoUJoLFYUw2IJpPsW8XNa1Db+aIHi1q8einOYAIc=; b=EM01nKv2pI7R8tPECQuzAvuQXefDljXgAzA1vkgFXumoyfUnSkZW4hwi qmGpP3KHE0aUYWcGFV3sbEJW9InAI4Oms/rRC4e/+arvgnvOz4k4TvPJO 0+CqZOl6lfqI0dYdKWp1HCI75R4jVCWqS21sqlpI+Fn0iqxfg/QAHLMEm M=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 21 Mar 2022 23:20:03 -0700 X-QCInternal: smtphost Received: from unknown (HELO nasanex01a.na.qualcomm.com) ([10.52.223.231]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2022 23:20:02 -0700 Received: from mingxue-gv.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 21 Mar 2022 23:19:59 -0700 Date: Tue, 22 Mar 2022 14:19:56 +0800 From: Minghao Xue To: Krzysztof Kozlowski CC: Jean-Philippe Brucker , , , , , , , Subject: Re: [PATCH] dt-bindings: virtio: mmio: add optional virtio,wakeup property Message-ID: <20220322061956.GA1441@mingxue-gv.qualcomm.com> References: <1646733156-19333-1-git-send-email-quic_mingxue@quicinc.com> <20220317063515.GA30789@mingxue-gv.qualcomm.com> <20220318021052.GA16300@mingxue-gv.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, Thanks for your comment. First of all, which "generic wakeup-source property" do you mean? Could you give an example? I find "wakeup-source" property in several binding files. Are you pointing to this? As my understanding, there is no standard naming rule about the property of each driver right? Currently, there's no virtio-mmio driver using this. Anyway, I can modify my patch, if you prefer "wakeup-source". Regards, Minghao On Fri, Mar 18, 2022 at 02:40:29PM +0100, Krzysztof Kozlowski wrote: > On 18/03/2022 03:10, Minghao Xue wrote: > > Hi Jean and folks, > > This is just an optional flag which could be used on an embedded system. > > For example, if we want to use an virtio-input device as a virtual power > > key to wake up the virtual machine, we can set this flag in the device > > tree. > > Currently, virio-mmio driver does not implement suspend/resume > > callback(maybe no need). So we want to check this flag and call > > enable_irq_wake() accordingly in vm_find_vqs(). > > There is a generic wakeup-source property. How is this one different > that you need a separate one? > > > Best regards, > Krzysztof