mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miles Chen <miles.chen@mediatek.com>
To: <liaoyu15@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <liwei391@huawei.com>,
	<marcel@holtmann.org>, <yake.yang@mediatek.com>
Subject: Re: [PATCH] Bluetooth: mt7921s: Fix a wrong judgment in btmtksdio_get_codec_config_data()
Date: Wed, 23 Mar 2022 06:57:00 +0800	[thread overview]
Message-ID: <20220322225700.16125-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220322023630.1239271-1-liaoyu15@huawei.com>

Hi Yu,

>Since ven_data is a double pointer, it should be *ven_data here.
>
>Fixes: f41b91fa1783 ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
>Signed-off-by: Yu Liao <liaoyu15@huawei.com>
>---
> drivers/bluetooth/btmtksdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
>index f3dc5881fff7..b6d77e04240c 100644
>--- a/drivers/bluetooth/btmtksdio.c
>+++ b/drivers/bluetooth/btmtksdio.c
>@@ -961,7 +961,7 @@ static int btmtksdio_get_codec_config_data(struct hci_dev *hdev,
> 	}
> 
> 	*ven_data = kmalloc(sizeof(__u8), GFP_KERNEL);
>-	if (!ven_data) {
>+	if (!*ven_data) {
> 		err = -ENOMEM;
> 		goto error;
> 	}

Thanks for fixing this.

Reviewed-by: Miles Chen <miles.chen@mediatek.com>

      reply	other threads:[~2022-03-22 22:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22  2:36 Yu Liao
2022-03-22 22:57 ` Miles Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220322225700.16125-1-miles.chen@mediatek.com \
    --to=miles.chen@mediatek.com \
    --cc=liaoyu15@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liwei391@huawei.com \
    --cc=marcel@holtmann.org \
    --cc=yake.yang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®