From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1703C433F5 for ; Thu, 24 Mar 2022 05:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347075AbiCXF6k (ORCPT ); Thu, 24 Mar 2022 01:58:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232029AbiCXF6h (ORCPT ); Thu, 24 Mar 2022 01:58:37 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C48193988; Wed, 23 Mar 2022 22:57:06 -0700 (PDT) X-UUID: eb6e6d1b03e74206b05e4b9be9c1a174-20220324 X-UUID: eb6e6d1b03e74206b05e4b9be9c1a174-20220324 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2025374543; Thu, 24 Mar 2022 13:57:01 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 24 Mar 2022 13:57:00 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 24 Mar 2022 13:57:00 +0800 From: Miles Chen To: CC: , , , , , , , , , , , , , Subject: Re: [PATCH v4 3/6] ASoC: dt-bindings: mediatek: mt8195: merge mt8195 machine yaml Date: Thu, 24 Mar 2022 13:57:00 +0800 Message-ID: <20220324055700.28736-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20220324053851.27350-4-trevor.wu@mediatek.com> References: <20220324053851.27350-4-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Because the same binding components can be shared by all codecs > combinations, we only reserve one binding file for mt8195 machine driver > and rename to a generic name. > > We use compatible string to separate different codec combination instead > of creating a new binding file for new codec combination. > > Signed-off-by: Trevor Wu >--- ...snip... >diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359.yaml >similarity index 87% >rename from Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml >rename to Documentation/devicetree/bindings/sound/mt8195-mt6359.yaml >index 8f177e02ad35..04953f5b44a4 100644 >--- a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1019-rt5682.yaml >+++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359.yaml >@@ -1,10 +1,10 @@ > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > %YAML 1.2 > --- >-$id: http://devicetree.org/schemas/sound/mt8195-mt6359-rt1019-rt5682.yaml# >+$id: http://devicetree.org/schemas/sound/mt8195-mt6359.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > >-title: Mediatek MT8195 with MT6359, RT1019 and RT5682 ASoC sound card driver >+title: MediaTek MT8195 ASoC sound card driver > I also tested: 'make dt_binding_check DT_CHECKER_FLAGS=-m DT_SCHEMA_FILES=Documentation/devicetree/bindings/sound/mt8195-mt6359.yaml' and it wotks fine. Reviewed-by: Miles Chen > maintainers: > - Trevor Wu >@@ -14,7 +14,9 @@ description: > > properties: > compatible: >- const: mediatek,mt8195_mt6359_rt1019_rt5682 >+ enum: >+ - mediatek,mt8195_mt6359_rt1019_rt5682 >+ - mediatek,mt8195_mt6359_rt1011_rt5682 > > model: > $ref: /schemas/types.yaml#/definitions/string >-- >2.18.0 > >