mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Cohen <dacohen@pm.me>
To: rafael@kernel.org, len.brown@intel.com, pavel@ucw.cz
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	David Cohen <dacohen@pm.me>
Subject: [PATCH v3 0/2] PM: refactor pm_pr_dbg() to support dynamic debug
Date: Thu, 24 Mar 2022 08:07:18 +0000	[thread overview]
Message-ID: <20220324080653.454333-1-dacohen@pm.me> (raw)

Hi,

I am currently debugging an issue with s2idle on my laptop where in a
rare occasion instead of sleeping, it gets stuck in an infinite loop.
The pm_pr_dbg() is placed on very useful functions and it helps me to
debug it, but the current all or nothing enabling mechanism with
pm_debug_messages_on flag is causing the suspending mechanism to be
disturbed with so many debug messages to the point it becomes extremely
difficult to reproduce the issue I'm debugging. More granularity when
enabling pm_pr_dbg() in this case is very welcome.

These patches I'm sending introduce dynamic debug support to pm_pr_dbg()
while still maintaining the pm_debug_messages_on flag behavior if
dynamic debug is not used.

Regards, David

---
David Cohen (2):
  PM: narrow down -DDEBUG on kernel/power/ files
  PM: enable dynamic debug support within pm_pr_dbg()

 include/linux/suspend.h | 44 ++++++++++++++++++++++++++++++++++++-----
 kernel/power/Makefile   |  6 +++++-
 kernel/power/main.c     | 29 ---------------------------
 kernel/power/process.c  |  3 ---
 4 files changed, 44 insertions(+), 38 deletions(-)

--
2.35.1



             reply	other threads:[~2022-03-24  8:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-24  8:07 David Cohen [this message]
2022-03-24  8:07 ` [PATCH v3 1/2] PM: narrow down -DDEBUG on kernel/power/ files David Cohen
2022-03-24  8:07 ` [PATCH v3 2/2] PM: enable dynamic debug support within pm_pr_dbg() David Cohen
2022-04-13 14:35 ` [PATCH v3 0/2] PM: refactor pm_pr_dbg() to support dynamic debug Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220324080653.454333-1-dacohen@pm.me \
    --to=dacohen@pm.me \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®