From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB085C433EF for ; Thu, 24 Mar 2022 23:15:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355694AbiCXXQw (ORCPT ); Thu, 24 Mar 2022 19:16:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244340AbiCXXQt (ORCPT ); Thu, 24 Mar 2022 19:16:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DCE34D25E for ; Thu, 24 Mar 2022 16:15:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ACEE4616D0 for ; Thu, 24 Mar 2022 23:15:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F356BC340EC; Thu, 24 Mar 2022 23:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1648163716; bh=gX2zLmWmZ8H5bi3l6ekaAnBAVIrb/aTIimGY60hPKx0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=omRla7Y/yQts8G6/qZlYUShApkMhkvu3ziS4rQm7HTDveh1JhszVBkdN9oBlilCbN G4kkwmWC7lf1bRmjhaq2H0sPzvjQkzTSoLCs3fpu5lTB5N6xRHDhNfD+s5goh8lsru 4f9jaVI5VAH1IlJrWjIm6Th9yBFBEl9FuEf53khg= Date: Thu, 24 Mar 2022 16:15:15 -0700 From: Andrew Morton To: Yinan Zhang Cc: Sean Anderson , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/vm/page_owner_sort.c: add switch between culling by stacktrace and txt Message-Id: <20220324161515.19e74f062210861d71ac414b@linux-foundation.org> In-Reply-To: <623bc151.1c69fb81.12d57.ef3cSMTPIN_ADDED_BROKEN@mx.google.com> References: <20211129145658.2491-1-zhangyinan2019@email.szu.edu.cn> <623a8074.1c69fb81.33a39.0d6cSMTPIN_ADDED_BROKEN@mx.google.com> <20220323120805.45fa9e5a0da60b861bf94671@linux-foundation.org> <623bc151.1c69fb81.12d57.ef3cSMTPIN_ADDED_BROKEN@mx.google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Mar 2022 08:54:34 +0800 Yinan Zhang wrote: > on 2022/3/24 3:08, Andrew Morton wrote: > > On Wed, 23 Mar 2022 10:05:28 +0800 Yinan Zhang wrote: > > > >>>> *(&list[i].txt+offset)) !=3D 0) { > >>>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 list2[count++] =3D list[i]; > >>>> =A0=A0=A0=A0=A0=A0=A0=A0=A0 } else { > >>>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 list2[count-1].num +=3D lis= t[i].num; > >>>> > >>> > >> You are right. Due to timestamp etc, it's almost impossible to > >> > >> cull by txt. And I did observe some blocks differ in head and same in > >> > >> stack trace on my linux. The examples I mentioned in patch are > >> > >> part of them. > >> > >> > >> Besides, --cull has been added in patch: > >> > >> tools/vm/page_owner_sort.c: support for user-defined culling rules > >> > > So should I drop this patch? >=20 > you decide. I'd rather not. And dropping this patch makes a huge mess of the series. So I either ask for the whole series to be redone and we might miss the merge window or I send it all in as-is. Sigh. I'll send it all in as-is. Please continue to work on this issue and if we decide to drop the -c option, please send along a patch to remove it over the next week or two.