From: Ali Saidi <alisaidi@amazon.com>
To: <acme@kernel.org>
Cc: <Nick.Forrington@arm.com>, <alexander.shishkin@linux.intel.com>,
<alisaidi@amazon.com>, <andrew.kilroy@arm.com>,
<benh@kernel.crashing.org>, <german.gomez@arm.com>,
<james.clark@arm.com>, <john.garry@huawei.com>,
<jolsa@kernel.org>, <kjain@linux.ibm.com>, <leo.yan@linaro.org>,
<lihuafei1@huawei.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>, <mark.rutland@arm.com>,
<mathieu.poirier@linaro.org>, <mingo@redhat.com>,
<namhyung@kernel.org>, <peterz@infradead.org>, <will@kernel.org>
Subject: Re: [PATCH v4 1/4] tools: arm64: Import cputype.h
Date: Fri, 25 Mar 2022 18:58:28 +0000 [thread overview]
Message-ID: <20220325185828.25461-1-alisaidi@amazon.com> (raw)
In-Reply-To: <Yj4McMHsxtJ3PfKk@kernel.org>
Hi Arnaldo,
On Fri, 25 Mar 2022 18:39:44 -0000, Arnaldo Carvalho de Melo wrote:
> Em Thu, Mar 24, 2022 at 06:33:20PM +0000, Ali Saidi escreveu:
> > Bring-in the kernel's arch/arm64/include/asm/cputype.h into tools/
> > for arm64 to make use of all the core-type definitions in perf.
> >
> > Replace sysreg.h with the version already imported into tools/.
>
> You forgot to add it to tools/perf/check-headers.sh so that we get
> notificed when the original file in the kernel sources gets updated, so
> that we can check if this needs any tooling adjustments.
Sorry.
> ⬢[acme@toolbox perf]$ diff -u tools/arch/arm64/include/asm/cputype.h arch/arm64/include/asm/cputype.h
> --- tools/arch/arm64/include/asm/cputype.h 2022-03-25 15:29:41.185173403 -0300
> +++ arch/arm64/include/asm/cputype.h 2022-03-22 17:52:10.881311839 -0300
> @@ -170,7 +170,7 @@
>
> #ifndef __ASSEMBLY__
>
> -#include "sysreg.h"
> +#include <asm/sysreg.h>
>
> #define read_cpuid(reg) read_sysreg_s(SYS_ ## reg)
>
> ⬢[acme@toolbox perf]$
>
>
> I'll add the entry together with the waiver for this specific
> difference.
Thank you!
It looks like it's been missed several times:
% find tools/arch/arm64 -type f
tools/arch/arm64/include/uapi/asm/unistd.h
tools/arch/arm64/include/uapi/asm/bpf_perf_event.h
tools/arch/arm64/include/uapi/asm/kvm.h
tools/arch/arm64/include/uapi/asm/mman.h
tools/arch/arm64/include/uapi/asm/perf_regs.h
tools/arch/arm64/include/uapi/asm/bitsperlong.h
tools/arch/arm64/include/asm/barrier.h
tools/arch/arm64/include/asm/cputype.h
tools/arch/arm64/include/asm/sysreg.h
% grep arm64 tools/perf/check-headers.sh
arch/arm64/include/uapi/asm/perf_regs.h
arch/arm64/include/uapi/asm/kvm.h
arch/arm64/include/uapi/asm/unistd.h
Thanks,
Ali
next prev parent reply other threads:[~2022-03-25 19:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 18:33 [PATCH v4 0/4] perf: arm-spe: Decode SPE source and use for perf c2c Ali Saidi
2022-03-24 18:33 ` [PATCH v4 1/4] tools: arm64: Import cputype.h Ali Saidi
2022-03-25 18:39 ` Arnaldo Carvalho de Melo
2022-03-25 18:58 ` Ali Saidi [this message]
2022-03-25 19:42 ` Arnaldo Carvalho de Melo
2022-03-26 5:49 ` Leo Yan
2022-03-26 13:59 ` Arnaldo Carvalho de Melo
2022-03-24 18:33 ` [PATCH v4 2/4] perf arm-spe: Use SPE data source for neoverse cores Ali Saidi
2022-03-26 13:47 ` Leo Yan
2022-03-26 13:52 ` Arnaldo Carvalho de Melo
2022-03-26 13:56 ` Leo Yan
2022-03-26 14:04 ` Arnaldo Carvalho de Melo
2022-03-26 19:43 ` Ali Saidi
2022-03-27 9:09 ` Leo Yan
2022-03-28 3:08 ` Ali Saidi
2022-03-28 13:05 ` Leo Yan
2022-03-29 13:34 ` Shuai Xue
2022-03-29 14:32 ` Ali Saidi
2022-03-31 12:19 ` Leo Yan
2022-03-31 12:28 ` German Gomez
2022-03-31 12:44 ` Leo Yan
2022-04-03 20:33 ` Ali Saidi
2022-04-04 15:12 ` Leo Yan
2022-04-06 21:00 ` Ali Saidi
2022-04-08 1:06 ` Leo Yan
2022-04-07 15:24 ` German Gomez
2022-04-08 1:18 ` Leo Yan
2022-03-24 18:33 ` [PATCH v4 3/4] perf mem: Support mem_lvl_num in c2c command Ali Saidi
2022-03-26 13:54 ` Arnaldo Carvalho de Melo
2022-03-24 18:33 ` [PATCH v4 4/4] perf mem: Support HITM for when mem_lvl_num is any Ali Saidi
2022-03-26 6:23 ` Leo Yan
2022-03-26 13:30 ` Arnaldo Carvalho de Melo
2022-03-26 19:14 ` Ali Saidi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325185828.25461-1-alisaidi@amazon.com \
--to=alisaidi@amazon.com \
--cc=Nick.Forrington@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrew.kilroy@arm.com \
--cc=benh@kernel.crashing.org \
--cc=german.gomez@arm.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=lihuafei1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®