Re: [PATCH v2] iio:filter:admv8818: select REGMAP_SPI for ADMV8818

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 21 Mar 2022 09:10:01 +0000
"Sa, Nuno" <Nuno.Sa@analog.com> wrote:

> > -----Original Message-----
> > From: Wang ShaoBo <bobo.shaobowang@huawei.com>
> > Sent: Sunday, March 20, 2022 6:55 AM
> > Cc: cj.chengjian@huawei.com; liwei391@huawei.com;
> > bobo.shaobowang@huawei.com; Miclaus, Antoniu
> > <Antoniu.Miclaus@analog.com>; Sa, Nuno <Nuno.Sa@analog.com>;
> > linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org;
> > jic23@kernel.org; Jonathan.Cameron@huawei.com
> > Subject: [PATCH v2] iio:filter:admv8818: select REGMAP_SPI for
> > ADMV8818
> > 
> > [External]
> > 
> > admv8818 driver needs __devm_regmap_init_spi() which is defined
> > when CONFIG_REGMAP_SPI is set and struct regmap_config when
> > CONFIG_REGMAP is set, so automatically select CONFIG_REGMAP_SPI
> > which also sets CONFIG_REGMAP.
> > 
> > Fixes: f34fe888ad05 ("iio:filter:admv8818: add support for ADMV8818")
> > Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
> > ---  
> 
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Applied to the fixes-togreg branch of iio.git but I'll not push that tree out
until I have had a chance to rebase on rc1.

Thanks,

Jonathan

> 
> >  drivers/iio/filter/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/iio/filter/Kconfig b/drivers/iio/filter/Kconfig
> > index 3ae35817ad82..a85b345ea14e 100644
> > --- a/drivers/iio/filter/Kconfig
> > +++ b/drivers/iio/filter/Kconfig
> > @@ -8,6 +8,7 @@ menu "Filters"
> >  config ADMV8818
> >  	tristate "Analog Devices ADMV8818 High-Pass and Low-Pass
> > Filter"
> >  	depends on SPI && COMMON_CLK && 64BIT
> > +	select REGMAP_SPI
> >  	help
> >  	  Say yes here to build support for Analog Devices ADMV8818
> >  	  2 GHz to 18 GHz, Digitally Tunable, High-Pass and Low-Pass
> > Filter.
> > --
> > 2.25.1  
>