From: Mario Limonciello <mario.limonciello@amd.com>
To: Huang Rui <ray.huang@amd.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: "open list:AMD PSTATE DRIVER" <linux-pm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH v2 3/3] cpufreq: amd-pstate: Add a module device table
Date: Mon, 28 Mar 2022 20:59:47 -0500 [thread overview]
Message-ID: <20220329015947.565-4-mario.limonciello@amd.com> (raw)
In-Reply-To: <20220329015947.565-1-mario.limonciello@amd.com>
`amd-pstate` currently only loads automatically if compiled into the
kernel. To improve the usability, add a module device table that
will load when AMD CPUs that support CPPC are detected.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v1->v2:
* Add comment to indicate need of SBIOS support.
drivers/cpufreq/amd-pstate.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 7dc2e344f222..9f78849654e7 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -705,6 +705,17 @@ static void __exit amd_pstate_exit(void)
amd_pstate_enable(false);
}
+/*
+ * This will only match the HW feature, there still needs to be appropriate
+ * SBIOS support, so it's possible that in such cases this causes a module
+ * load with -ENODEV as the result.
+ */
+static const struct x86_cpu_id __maybe_unused amd_pstate_ids[] = {
+ X86_MATCH_VENDOR_FEATURE(AMD, X86_FEATURE_CPPC, NULL),
+ {}
+};
+MODULE_DEVICE_TABLE(x86cpu, amd_pstate_ids);
+
module_init(amd_pstate_init);
module_exit(amd_pstate_exit);
--
2.34.1
next prev parent reply other threads:[~2022-03-29 2:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 1:59 [PATCH v2 0/3] Improve usability for amd-pstate Mario Limonciello
2022-03-29 1:59 ` [PATCH v2 1/3] cpufreq: Export acpu_cpufreq_exit for other drivers to call Mario Limonciello
2022-03-29 5:47 ` Huang Rui
2022-03-29 6:22 ` kernel test robot
2022-03-29 6:32 ` kernel test robot
2022-03-29 1:59 ` [PATCH v2 2/3] cpufreq: amd-pstate: Allow replacing acpi-cpufreq when loaded Mario Limonciello
2022-03-29 5:56 ` Huang Rui
2022-03-29 1:59 ` Mario Limonciello [this message]
2022-03-29 5:56 ` [PATCH v2 3/3] cpufreq: amd-pstate: Add a module device table Huang Rui
2022-03-29 6:02 ` [PATCH v2 0/3] Improve usability for amd-pstate Huang Rui
2022-03-29 20:47 ` Limonciello, Mario
2022-03-30 9:54 ` Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329015947.565-4-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®