From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C5C8C433EF for ; Wed, 30 Mar 2022 06:52:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243450AbiC3Gy3 (ORCPT ); Wed, 30 Mar 2022 02:54:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243442AbiC3Gy0 (ORCPT ); Wed, 30 Mar 2022 02:54:26 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 478FCB6E6B for ; Tue, 29 Mar 2022 23:52:37 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZSBz-0004hy-4h; Wed, 30 Mar 2022 08:52:31 +0200 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nZSBy-0007QK-7D; Wed, 30 Mar 2022 08:52:30 +0200 Date: Wed, 30 Mar 2022 08:52:30 +0200 From: Michael Tretter To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , Marek Vasut , Sakari Ailus , Pengutronix Kernel Team , linux-media@vger.kernel.org, Mauro Carvalho Chehab Subject: Re: [PATCH -next] media: isl7998x: select V4L2_FWNODE to fix build error Message-ID: <20220330065230.GE20418@pengutronix.de> Mail-Followup-To: Michael Tretter , Randy Dunlap , linux-kernel@vger.kernel.org, kernel test robot , Marek Vasut , Sakari Ailus , Pengutronix Kernel Team , linux-media@vger.kernel.org, Mauro Carvalho Chehab References: <20220330015652.5420-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220330015652.5420-1-rdunlap@infradead.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:51:01 up 109 days, 15:36, 75 users, load average: 0.09, 0.10, 0.14 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Mar 2022 18:56:52 -0700, Randy Dunlap wrote: > Fix build error when VIDEO_ISL7998X=y and V4L2_FWNODE=m > by selecting V4L2_FWNODE. > > microblaze-linux-ld: drivers/media/i2c/isl7998x.o: in function `isl7998x_probe': > (.text+0x8f4): undefined reference to `v4l2_fwnode_endpoint_parse' > > Fixes: 51ef2be546e2 ("media: i2c: isl7998x: Add driver for Intersil ISL7998x") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Cc: Marek Vasut > Cc: Sakari Ailus > Cc: Michael Tretter > Cc: Pengutronix Kernel Team > Cc: linux-media@vger.kernel.org > Cc: Mauro Carvalho Chehab Reviewed-by: Michael Tretter > --- > drivers/media/i2c/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20220329.orig/drivers/media/i2c/Kconfig > +++ linux-next-20220329/drivers/media/i2c/Kconfig > @@ -1177,6 +1177,7 @@ config VIDEO_ISL7998X > depends on OF_GPIO > select MEDIA_CONTROLLER > select VIDEO_V4L2_SUBDEV_API > + select V4L2_FWNODE > help > Support for Intersil ISL7998x analog to MIPI-CSI2 or > BT.656 decoder. >