From: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
To: <wim@linux-watchdog.org>, <linux@roeck-us.net>,
<geert+renesas@glider.be>, <linux-watchdog@vger.kernel.org>
Cc: <linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Subject: [PATCH v4 0/2] ARM: r9a06g032: add support for the watchdogs
Date: Wed, 30 Mar 2022 12:08:27 +0200 [thread overview]
Message-ID: <20220330100829.1000679-1-jjhiblot@traphandler.com> (raw)
Hi all,
This series adds support for the watchdog timers of the RZ/N1.
The watchdog driver (rzn1-wdt.c) is derived from the driver available at
https://github.com/renesas-rz/rzn1_linux.git with a few modifications
In order to be able to reset the board when a watchdog timer expires,
the RSTEN register must be configured. it is the responsability of the
bootloader to set those bits (or not, depending on the chosen policy).
If the watchdog reset source is not enabled, an interrupt is triggered
when the watchdog expires. The interrupt handler will trigger an
emergency restart.
Changes v3 -> v4:
* dts: removed the patches that modify the device tree (already taken in
the renesas dt tree)
* driver: Call emergency_restart() in the interrupt handler.
Changes v2 -> v3:
* dts: changed compatible strings to include "renesas,r9a06g032-wdt" and
"renesas,rzn1-wdt".
* driver: removed the SOC-specific "renesas,r9a06g032-wdt".
* removed all the changes in the clock driver: the watchdog reset source
are not disabled anymore when the machine is halted.
* fixed the clock rate type in the computations.
* removed unnecessary printout and call to clk_disable_unprepare() in the
driver probe().
Changes v1 -> v2:
* Modified the clock driver to not enable the watchdog reset sources.
On other renesas platforms, those bits are by the bootloader. The
watchdog reset sources are still disabled when the platform is halted
to prevent a watchdog reset.
* Added a SOC-specific compatible "renesas,r9a06g032-wdt"
* reordered the dts/i entries
* default timeout is 60 seconds
* reworked the probe function of the wdt driver to better error cases
* removed the set_timeout() and use a fixed period computed in probe().
This removes the confusion and makes it clear that the period defined
by the user space in indeed handled by the watchdog core
Jean-Jacques Hiblot (1):
dt-bindings: watchdog: renesas,wdt: Add support for RZ/N1
Phil Edworthy (1):
watchdog: Add Renesas RZ/N1 Watchdog driver
.../bindings/watchdog/renesas,wdt.yaml | 6 +
drivers/watchdog/Kconfig | 8 +
drivers/watchdog/Makefile | 1 +
drivers/watchdog/rzn1_wdt.c | 207 ++++++++++++++++++
4 files changed, 222 insertions(+)
create mode 100644 drivers/watchdog/rzn1_wdt.c
--
2.25.1
next reply other threads:[~2022-03-30 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 10:08 Jean-Jacques Hiblot [this message]
2022-03-30 10:08 ` [PATCH v4 1/2] dt-bindings: watchdog: renesas,wdt: Add support for RZ/N1 Jean-Jacques Hiblot
2022-03-30 10:08 ` [PATCH v4 2/2] watchdog: Add Renesas RZ/N1 Watchdog driver Jean-Jacques Hiblot
2022-03-31 6:08 ` Tzung-Bi Shih
2022-04-01 2:26 ` Guenter Roeck
2022-04-01 13:03 ` Jean-Jacques Hiblot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330100829.1000679-1-jjhiblot@traphandler.com \
--to=jjhiblot@traphandler.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®