From: Xiaomeng Tong <xiam0nd.tong@gmail.com>
To: patrik.r.jakobsson@gmail.com, airlied@linux.ie, daniel@ffwll.ch
Cc: rob@ti.com, yakui.zhao@intel.com, airlied@redhat.com,
alan@linux.intel.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Xiaomeng Tong <xiam0nd.tong@gmail.com>
Subject: [PATCH 3/5] gma500: fix a missing break in psb_intel_crtc_mode_set
Date: Wed, 30 Mar 2022 20:02:44 +0800 [thread overview]
Message-ID: <20220330120246.25580-4-xiam0nd.tong@gmail.com> (raw)
In-Reply-To: <20220330120246.25580-1-xiam0nd.tong@gmail.com>
Instead of exiting the loop as expected when an entry is found, the
list_for_each_entry() continues until the traversal is complete. It
could result in multiple 'is_*' flags being set with true mistakely.
To fix this, when found the entry, add a break after the switch
statement.
Fixes: 89c78134cc54d (" gma500: Add Poulsbo support")
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
---
drivers/gpu/drm/gma500/psb_intel_display.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c
index 42d1a733e124..85fc61bf333a 100644
--- a/drivers/gpu/drm/gma500/psb_intel_display.c
+++ b/drivers/gpu/drm/gma500/psb_intel_display.c
@@ -134,6 +134,8 @@ static int psb_intel_crtc_mode_set(struct drm_crtc *crtc,
is_tv = true;
break;
}
+
+ break;
}
refclk = 96000;
--
2.17.1
next prev parent reply other threads:[~2022-03-30 12:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 12:02 [PATCH 0/5] fix missing break in list_or_each_entry Xiaomeng Tong
2022-03-30 12:02 ` [PATCH 1/5] gma500: fix a missing break in oaktrail_crtc_mode_set Xiaomeng Tong
2022-04-01 9:25 ` Patrik Jakobsson
2022-03-30 12:02 ` [PATCH 2/5] gma500: fix a missing break in cdv_intel_crtc_mode_set Xiaomeng Tong
2022-04-01 9:28 ` Patrik Jakobsson
2022-03-30 12:02 ` Xiaomeng Tong [this message]
2022-04-01 9:53 ` [PATCH 3/5] gma500: fix a missing break in psb_intel_crtc_mode_set Patrik Jakobsson
2022-04-01 11:07 ` Xiaomeng Tong
2022-03-30 12:02 ` [PATCH 4/5] gma500: fix a missing break in cdv_intel_dp_set_m_n Xiaomeng Tong
2022-04-01 10:03 ` Patrik Jakobsson
2022-03-30 12:02 ` [PATCH 5/5] gma500: fix a missing break in psb_driver_load Xiaomeng Tong
2022-04-01 10:10 ` Patrik Jakobsson
2022-04-01 11:16 ` Xiaomeng Tong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330120246.25580-4-xiam0nd.tong@gmail.com \
--to=xiam0nd.tong@gmail.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=alan@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=rob@ti.com \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®