From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E0C6C433EF for ; Wed, 30 Mar 2022 07:24:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243785AbiC3H0I (ORCPT ); Wed, 30 Mar 2022 03:26:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243798AbiC3H0A (ORCPT ); Wed, 30 Mar 2022 03:26:00 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B45E1B30B8 for ; Wed, 30 Mar 2022 00:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648625055; x=1680161055; h=date:from:to:cc:subject:message-id:mime-version; bh=OSZhe1LH70z9FjGnc3VQS/kWLAqR1viJqF+BQhXGc4Q=; b=Lt3LMPyOOhoMf+bomsk2pekLqeLXpnLZDRCMbIzuYYNuRMVbhD6weTT1 fBTSpc8E6I55Am4PB1oWCHFdH3HcWd8oCyCeIQuA1thgT5bjlJhwc9CFr 3aoxk5p6OaARO6e3aIvMeQi6XoYkpwHnuaha4Dr0L9p43dP46hAk5y6yy Xug0ZjSwp1NPhmXn0Pxak/MyS+DmlLBthOp+Q5iJjXZMT79/aUrIbaxiI tETGWthKDC2pw0mG8X1LBu7+cn8a3m+kPac4V8hY+sUZUOqNAwDM8HBt8 Yehe+YyQoSyR/BwsD4CtTi13/ssMFfPPkewRclTWxJ7+KOB0/BlKkZAm1 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10301"; a="240067598" X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="240067598" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 00:24:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="546743295" Received: from lkp-server02.sh.intel.com (HELO 7a008980c4ea) ([10.239.97.151]) by orsmga007.jf.intel.com with ESMTP; 30 Mar 2022 00:24:12 -0700 Received: from kbuild by 7a008980c4ea with local (Exim 4.92) (envelope-from ) id 1nZSgd-00000z-QM; Wed, 30 Mar 2022 07:24:11 +0000 Date: Wed, 30 Mar 2022 15:23:42 +0800 From: kernel test robot To: John Garry Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" Subject: drivers/scsi/hisi_sas/hisi_sas_main.c:445 hisi_sas_task_deliver() warn: inconsistent indenting Message-ID: <202203301533.b4Hty4C7-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 1c24a186398f59c80adb9a967486b65c1423a59d commit: 095478a6e5bf590f2bbf341569eb25173c9c5f32 scsi: hisi_sas: Use libsas internal abort support date: 2 weeks ago config: powerpc64-randconfig-m031-20220330 (https://download.01.org/0day-ci/archive/20220330/202203301533.b4Hty4C7-lkp@intel.com/config) compiler: powerpc64-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot smatch warnings: drivers/scsi/hisi_sas/hisi_sas_main.c:445 hisi_sas_task_deliver() warn: inconsistent indenting vim +445 drivers/scsi/hisi_sas/hisi_sas_main.c b3cce125cb1e2e Xiang Chen 2019-02-06 393 dc313f6b125b09 John Garry 2021-12-15 394 static dc313f6b125b09 John Garry 2021-12-15 395 void hisi_sas_task_deliver(struct hisi_hba *hisi_hba, dc313f6b125b09 John Garry 2021-12-15 396 struct hisi_sas_slot *slot, dc313f6b125b09 John Garry 2021-12-15 397 struct hisi_sas_dq *dq, 095478a6e5bf59 John Garry 2022-03-11 398 struct hisi_sas_device *sas_dev) 42e7a69368a585 John Garry 2015-11-18 399 { 42e7a69368a585 John Garry 2015-11-18 400 struct hisi_sas_cmd_hdr *cmd_hdr_base; dc313f6b125b09 John Garry 2021-12-15 401 int dlvry_queue_slot, dlvry_queue; dc313f6b125b09 John Garry 2021-12-15 402 struct sas_task *task = slot->task; fa222db0b03689 Xiang Chen 2018-05-09 403 int wr_q_index; 42e7a69368a585 John Garry 2015-11-18 404 e9dc5e11c97ee9 Xiang Chen 2020-01-20 405 spin_lock(&dq->lock); 897cc769bcc092 John Garry 2019-08-05 406 wr_q_index = dq->wr_point; 897cc769bcc092 John Garry 2019-08-05 407 dq->wr_point = (dq->wr_point + 1) % HISI_SAS_QUEUE_SLOTS; fa222db0b03689 Xiang Chen 2018-05-09 408 list_add_tail(&slot->delivery, &dq->list); e9dc5e11c97ee9 Xiang Chen 2020-01-20 409 spin_unlock(&dq->lock); e9dc5e11c97ee9 Xiang Chen 2020-01-20 410 spin_lock(&sas_dev->lock); 4fefe5bbf599d6 Xiang Chen 2019-02-06 411 list_add_tail(&slot->entry, &sas_dev->list); e9dc5e11c97ee9 Xiang Chen 2020-01-20 412 spin_unlock(&sas_dev->lock); 42e7a69368a585 John Garry 2015-11-18 413 b1a49412f0aed7 Xiang Chen 2017-06-14 414 dlvry_queue = dq->id; fa222db0b03689 Xiang Chen 2018-05-09 415 dlvry_queue_slot = wr_q_index; 42e7a69368a585 John Garry 2015-11-18 416 4fefe5bbf599d6 Xiang Chen 2019-02-06 417 slot->device_id = sas_dev->device_id; 42e7a69368a585 John Garry 2015-11-18 418 slot->dlvry_queue = dlvry_queue; 42e7a69368a585 John Garry 2015-11-18 419 slot->dlvry_queue_slot = dlvry_queue_slot; 42e7a69368a585 John Garry 2015-11-18 420 cmd_hdr_base = hisi_hba->cmd_hdr[dlvry_queue]; 42e7a69368a585 John Garry 2015-11-18 421 slot->cmd_hdr = &cmd_hdr_base[dlvry_queue_slot]; dc313f6b125b09 John Garry 2021-12-15 422 42e7a69368a585 John Garry 2015-11-18 423 task->lldd_task = slot; 42e7a69368a585 John Garry 2015-11-18 424 42e7a69368a585 John Garry 2015-11-18 425 memset(slot->cmd_hdr, 0, sizeof(struct hisi_sas_cmd_hdr)); f557e32c0023ea Xiaofei Tan 2017-06-29 426 memset(hisi_sas_cmd_hdr_addr_mem(slot), 0, HISI_SAS_COMMAND_TABLE_SZ); d380f55503ed28 Xiang Chen 2019-08-05 427 memset(hisi_sas_status_buf_addr_mem(slot), 0, d380f55503ed28 Xiang Chen 2019-08-05 428 sizeof(struct hisi_sas_err_record)); 42e7a69368a585 John Garry 2015-11-18 429 42e7a69368a585 John Garry 2015-11-18 430 switch (task->task_proto) { 66ee999b4e43e1 John Garry 2015-11-18 431 case SAS_PROTOCOL_SMP: a2b3820bddfbff Xiang Chen 2018-05-09 432 hisi_sas_task_prep_smp(hisi_hba, slot); 66ee999b4e43e1 John Garry 2015-11-18 433 break; 42e7a69368a585 John Garry 2015-11-18 434 case SAS_PROTOCOL_SSP: 78bd2b4f6e7c05 Xiaofei Tan 2018-05-21 435 hisi_sas_task_prep_ssp(hisi_hba, slot); 42e7a69368a585 John Garry 2015-11-18 436 break; 42e7a69368a585 John Garry 2015-11-18 437 case SAS_PROTOCOL_SATA: 42e7a69368a585 John Garry 2015-11-18 438 case SAS_PROTOCOL_STP: 095478a6e5bf59 John Garry 2022-03-11 439 case SAS_PROTOCOL_STP_ALL: a2b3820bddfbff Xiang Chen 2018-05-09 440 hisi_sas_task_prep_ata(hisi_hba, slot); 6f2ff1a1311e61 John Garry 2016-01-26 441 break; 095478a6e5bf59 John Garry 2022-03-11 442 case SAS_PROTOCOL_INTERNAL_ABORT: 095478a6e5bf59 John Garry 2022-03-11 443 hisi_sas_task_prep_abort(hisi_hba, slot); dc313f6b125b09 John Garry 2021-12-15 444 break; dc313f6b125b09 John Garry 2021-12-15 @445 fallthrough; 42e7a69368a585 John Garry 2015-11-18 446 default: 095478a6e5bf59 John Garry 2022-03-11 447 return; 42e7a69368a585 John Garry 2015-11-18 448 } 42e7a69368a585 John Garry 2015-11-18 449 1c09b663168bb5 Xiaofei Tan 2018-07-18 450 WRITE_ONCE(slot->ready, 1); 42e7a69368a585 John Garry 2015-11-18 451 0e4620856b8933 John Garry 2021-12-15 452 spin_lock(&dq->lock); 0e4620856b8933 John Garry 2021-12-15 453 hisi_hba->hw->start_delivery(dq); 0e4620856b8933 John Garry 2021-12-15 454 spin_unlock(&dq->lock); 42e7a69368a585 John Garry 2015-11-18 455 } 42e7a69368a585 John Garry 2015-11-18 456 :::::: The code at line 445 was first introduced by commit :::::: dc313f6b125b095d3d2683d94d5f69c8dc9bdc36 scsi: hisi_sas: Factor out task prep and delivery code :::::: TO: John Garry :::::: CC: Martin K. Petersen -- 0-DAY CI Kernel Test Service https://01.org/lkp