From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59E83C433F5 for ; Wed, 30 Mar 2022 22:29:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351617AbiC3WbJ (ORCPT ); Wed, 30 Mar 2022 18:31:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233684AbiC3WbH (ORCPT ); Wed, 30 Mar 2022 18:31:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2318C5BD10 for ; Wed, 30 Mar 2022 15:29:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BD61A617C1 for ; Wed, 30 Mar 2022 22:29:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F106AC3410F; Wed, 30 Mar 2022 22:29:19 +0000 (UTC) Date: Wed, 30 Mar 2022 18:29:18 -0400 From: Steven Rostedt To: Zi Yan Cc: Zi Yan , Linus Torvalds , David Hildenbrand , Vlastimil Babka , Mel Gorman , Mike Rapoport , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: page_alloc: validate buddy before check its migratetype. Message-ID: <20220330182918.38276a89@gandalf.local.home> In-Reply-To: <20220330221238.396357-1-zi.yan@sent.com> References: <20220330221238.396357-1-zi.yan@sent.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Mar 2022 18:12:38 -0400 Zi Yan wrote: > From: Zi Yan > > Whenever a buddy page is found, page_is_buddy() should be called to > check its validity. Add the missing check during pageblock merge check. > > Fixes: 1dd214b8f21c ("mm: page_alloc: avoid merging non-fallbackable pageblocks with others") Link: https://lore.kernel.org/all/20220330154208.71aca532@gandalf.local.home/ > > Reported-by: Steven Rostedt Tested-by: Steven Rostedt (Google) -- Steve > Signed-off-by: Zi Yan > --- > mm/page_alloc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index bdc8f60ae462..6c6af8658775 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1108,6 +1108,9 @@ static inline void __free_one_page(struct page *page, > > buddy_pfn = __find_buddy_pfn(pfn, order); > buddy = page + (buddy_pfn - pfn); > + > + if (!page_is_buddy(page, buddy, order)) > + goto done_merging; > buddy_mt = get_pageblock_migratetype(buddy); > > if (migratetype != buddy_mt