From: trix@redhat.com
To: marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Rix <trix@redhat.com>
Subject: [PATCH] Bluetooth: btintel: fix btintel_download_firmware stub signature
Date: Thu, 31 Mar 2022 10:49:59 -0700 [thread overview]
Message-ID: <20220331174959.3421978-1-trix@redhat.com> (raw)
From: Tom Rix <trix@redhat.com>
cppcheck returns this warning
btintel.c:1059]: (warning) Function 'btintel_download_firmware'
argument order different: declaration
'dev, fw, boot_param, ' definition 'hdev, ver, fw, boot_param'
By inspection, the stub version is missing
'struct intel_version *ver', so add it.
Fixes: ac0565462e33 ("Bluetooth: btintel: Check firmware version before download")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/bluetooth/btintel.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h
index e0060e58573c..66902866a5c1 100644
--- a/drivers/bluetooth/btintel.h
+++ b/drivers/bluetooth/btintel.h
@@ -281,6 +281,7 @@ static inline int btintel_read_boot_params(struct hci_dev *hdev,
}
static inline int btintel_download_firmware(struct hci_dev *dev,
+ struct intel_version *ver,
const struct firmware *fw,
u32 *boot_param)
{
--
2.26.3
next reply other threads:[~2022-03-31 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 17:49 trix [this message]
2022-04-01 17:22 ` Marcel Holtmann
2022-04-01 17:33 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331174959.3421978-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®