From: "Luís Henriques" <lhenriques@suse.de>
To: Jeff Layton <jlayton@kernel.org>, Xiubo Li <xiubli@redhat.com>,
Ilya Dryomov <idryomov@gmail.com>
Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
"Luís Henriques" <lhenriques@suse.de>
Subject: [PATCH] ceph: truncate page cache when doing DIO in encrypted inodes
Date: Fri, 1 Apr 2022 12:38:22 +0100 [thread overview]
Message-ID: <20220401113822.32545-1-lhenriques@suse.de> (raw)
When doing DIO on an encrypted node, we need to truncate the page cache in
the range being written to, otherwise the cache will include invalid data.
Signed-off-by: Luís Henriques <lhenriques@suse.de>
---
fs/ceph/file.c | 5 +++++
1 file changed, 5 insertions(+)
This patch should fix generic/647 fstest when run with test_dummy_encryption.
diff --git a/fs/ceph/file.c b/fs/ceph/file.c
index 5072570c2203..0f31c4d352a4 100644
--- a/fs/ceph/file.c
+++ b/fs/ceph/file.c
@@ -1895,6 +1895,11 @@ ceph_sync_write(struct kiocb *iocb, struct iov_iter *from, loff_t pos,
req->r_inode = inode;
req->r_mtime = mtime;
+ if (IS_ENCRYPTED(inode) && (iocb->ki_flags & IOCB_DIRECT))
+ truncate_inode_pages_range(
+ inode->i_mapping, write_pos,
+ PAGE_ALIGN(write_pos + write_len) - 1);
+
/* Set up the assertion */
if (rmw) {
/*
next reply other threads:[~2022-04-01 11:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 11:38 Luís Henriques [this message]
2022-04-01 11:56 ` Jeff Layton
2022-04-01 12:15 ` Luís Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220401113822.32545-1-lhenriques@suse.de \
--to=lhenriques@suse.de \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome