From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D180C433EF for ; Fri, 1 Apr 2022 11:50:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345644AbiDALwe (ORCPT ); Fri, 1 Apr 2022 07:52:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242890AbiDALwc (ORCPT ); Fri, 1 Apr 2022 07:52:32 -0400 Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50F3A1D4C3D for ; Fri, 1 Apr 2022 04:50:43 -0700 (PDT) Received: by mail-qt1-x829.google.com with SMTP id v2so1918180qtc.5 for ; Fri, 01 Apr 2022 04:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=aWU5ex06rg/AbNFctgOjoJ+VPR4oCqibVD3GK7DdDdo=; b=Qyy3Udw8VF5Ot//VwLar51rfmkwCFBDzCnSF6Gf9f8KzXztMaOS0Bf8klFPdc4rhkS qWuajiA0GbmB02qlYfdQXTKlNa+WarFwE0QLpGuBXjIzJtAOaMIAhiWzs2KiYwS8+sa8 iJEyhURgJ2kgurgxXoEtTXICZzT8NZcuxN+J74FTu1LtT8dHsd5xOtJpnJwPL0AoaElP NDy2gnD9jSf+AuVwK9YJeJkfZcYvIHodQUCbEB/o+k4bLIdpFLEyVvYqQaMfqqdBJNNV KjqXnimN6f285Yq1Z3jbp2o7g4Pz/rwVJA+NFMOewjcPkrXP5vXkOplN3Xog+1J2f3ve bE8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=aWU5ex06rg/AbNFctgOjoJ+VPR4oCqibVD3GK7DdDdo=; b=O2o6t5Tja5PEPyjheiK56UURnVpGmA5gzoDpss8tkY+ctnFpSg50QIVxPxueHAyKlV 1rx9xsQCeqCOgibqyWCNJei6B46yPTZUChYSCi6ghs8TzRGjH2FVN9JOC4+w9pN0tPJt gBVzBirnfdZ9eVRKFxqTkt7JheVmDmqgQ0ZejTg7HNeNnn7jTDLBZjToFTpuJ/layorv 2Iop+fV2NGKJOU744bY4C3bSiBAUkjyRTMpgQgTjFPKbVLKCsZj97UCC6Zhul8CS+ijg lp97kUUXfxJqXx3Z0+w39w5UjnOC/VIgJEVV7llZTQddb3yrFk5mzaq0jGFMJBkrWc1o RaOw== X-Gm-Message-State: AOAM533j4HG8xKIHlzuTG/79Ar3+qZCzdqPHatA8bdjd/7q+wp1+5dXn rJcZoMq00NW7q3aJq/yJmAPpkw== X-Google-Smtp-Source: ABdhPJyfCcvq7CBX9wgoBhMFIjFHkhgqRfs3elmzeEMluYtBMOrfnZch8qYIwPkBbG5DDeM5pPgVDA== X-Received: by 2002:a05:622a:164f:b0:2e1:d4b7:b208 with SMTP id y15-20020a05622a164f00b002e1d4b7b208mr8122507qtj.84.1648813842430; Fri, 01 Apr 2022 04:50:42 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id t7-20020a05622a01c700b002e1b3555c2fsm1626596qtw.26.2022.04.01.04.50.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 04:50:41 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1naFnb-00ANpp-Tn; Fri, 01 Apr 2022 08:50:39 -0300 Date: Fri, 1 Apr 2022 08:50:39 -0300 From: Jason Gunthorpe To: cgel.zte@gmail.com Cc: mike.marciniszyn@cornelisnetworks.com, dennis.dalessandro@cornelisnetworks.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Lv Ruyi , Zeal Robot Subject: Re: [PATCH] RDMA: Replace zero-length array with flexible-array member Message-ID: <20220401115039.GO64706@ziepe.ca> References: <20220401075406.2407294-1-lv.ruyi@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220401075406.2407294-1-lv.ruyi@zte.com.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 01, 2022 at 07:54:06AM +0000, cgel.zte@gmail.com wrote: > From: Lv Ruyi > > There is a regular need in the kernel to provide a way to declare > having a dynamically sized set of trailing elements in a structure. > Kernel code should always use “flexible array members”[1] for these > cases. The older style of one-element or zero-length arrays should > no longer be used[2]. If I recall properly this doesn't work if the flex array is nested inside another member.. Not sure what this thinks it is doing anyhow Jason