From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BBB5C43217 for ; Fri, 1 Apr 2022 15:20:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350160AbiDAPSj (ORCPT ); Fri, 1 Apr 2022 11:18:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352337AbiDAOuP (ORCPT ); Fri, 1 Apr 2022 10:50:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E63D929341D; Fri, 1 Apr 2022 07:41:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8F30C611C6; Fri, 1 Apr 2022 14:40:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EEE0C3410F; Fri, 1 Apr 2022 14:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648824024; bh=vGF3y5k+Md9JoYlQ/HpFasDzK2ORKMQo7WzM+vUcTPQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LB0Q5yJ/zBQobiKcMwstGy6QYFOHp4XPj/bL3a7X2iiDCyEtHK87F/2loiKxYABNp hgyszgbbU+poUvhH4XCNIt5bgNCZ3GKD/kkKAgfAPr1Wf4xMD3TcPcKIoQg5hD1xe+ dxgwVdMKoKwcHw43VVMOETmszFu1a8XEvEomcjfwKxY2ql5GN+bPmGZQak1CRm9Ega zkGezCFvQEzqHPnwDUF8v1Xyi0f/JpKNQoF1Z0zOAGwlnzAZa5QeihOqtnYn1DsQ+E GUsUJGqGwTfUMj6zhcTQa/xQKOo91XxYMe6Q+kc61hjMbG2NIW3r7Fe6PmAqDLYEmJ sCVmWXZbFQ9Pg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Damien Le Moal , Jack Wang , "Martin K . Petersen" , Sasha Levin , jinpu.wang@cloud.ionos.com, jejb@linux.ibm.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 57/98] scsi: pm8001: Fix memory leak in pm8001_chip_fw_flash_update_req() Date: Fri, 1 Apr 2022 10:37:01 -0400 Message-Id: <20220401143742.1952163-57-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220401143742.1952163-1-sashal@kernel.org> References: <20220401143742.1952163-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Damien Le Moal [ Upstream commit f792a3629f4c4aa4c3703d66b43ce1edcc3ec09a ] In pm8001_chip_fw_flash_update_build(), if pm8001_chip_fw_flash_update_build() fails, the struct fw_control_ex allocated must be freed. Link: https://lore.kernel.org/r/20220220031810.738362-23-damien.lemoal@opensource.wdc.com Reviewed-by: Jack Wang Signed-off-by: Damien Le Moal Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/pm8001/pm8001_hwi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c index d0e8e6c2f87d..caf5bcb367e4 100644 --- a/drivers/scsi/pm8001/pm8001_hwi.c +++ b/drivers/scsi/pm8001/pm8001_hwi.c @@ -4900,8 +4900,10 @@ pm8001_chip_fw_flash_update_req(struct pm8001_hba_info *pm8001_ha, ccb->ccb_tag = tag; rc = pm8001_chip_fw_flash_update_build(pm8001_ha, &flash_update_info, tag); - if (rc) + if (rc) { + kfree(fw_control_context); pm8001_tag_free(pm8001_ha, tag); + } return rc; } -- 2.34.1