From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11E97C433EF for ; Fri, 1 Apr 2022 19:55:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351262AbiDAT5g (ORCPT ); Fri, 1 Apr 2022 15:57:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233319AbiDAT5d (ORCPT ); Fri, 1 Apr 2022 15:57:33 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C01C14FFCD for ; Fri, 1 Apr 2022 12:55:43 -0700 (PDT) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 231JtLNd078613; Fri, 1 Apr 2022 14:55:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1648842921; bh=PKlCkQuLNfKhUJdeMTsEMFy8vaBduxctt04jBNunlYs=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=y938O2KVxf78VOHFRyhYuy8I9mnmg8AUjedVrnmh1ddFAmKaRmDvALq+cWjn9T2np 2sbgq8pQ3Bwh7TCMZf2YxuxO2efniPW5wBBJLeVDUYQzogQGN1OKk9x9Lkoo9gQSYJ 0dGvcJy6DJAGriJiTlDh/89jioEx9u72FMigmkFc= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 231JtL7t098959 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 1 Apr 2022 14:55:21 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 1 Apr 2022 14:55:20 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Fri, 1 Apr 2022 14:55:20 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 231JtKuQ041523; Fri, 1 Apr 2022 14:55:20 -0500 Date: Sat, 2 Apr 2022 01:25:19 +0530 From: Pratyush Yadav To: Tudor Ambarus CC: , , , , , , Subject: Re: [PATCH v2 3/4] mtd: spi-nor: Favor the BFPT-parsed set_4byte_addr_mode method Message-ID: <20220401195519.chzdrnb6vdf6jlos@ti.com> References: <20220309144215.179449-1-tudor.ambarus@microchip.com> <20220309144215.179449-4-tudor.ambarus@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220309144215.179449-4-tudor.ambarus@microchip.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/03/22 04:42PM, Tudor Ambarus wrote: > JESD216 SFDP defines in the BFPT standard methods to enter and exit the > 4-Byte Address Mode. The flash parameters and settings that are retrieved > from SFDP have higher precedence than the static initialized ones, because > they should be more accurate and less error prone than those initialized > statically. Favor the BFPT-parsed set_4byte_addr_mode method and use the > generic core methods where possible. > This patch may introduce regressions in case BFPT contains wrong data. The > fix is to introduce a post_bfpt() fixup hook and update the wrong BFPT > data. > > Signed-off-by: Tudor Ambarus Reviewed-by: Pratyush Yadav -- Regards, Pratyush Yadav Texas Instruments Inc.