mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: lienze@kylinos.cn
Cc: nathan@kernel.org, ndesaulniers@google.com,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	linux-block@vger.kernel.org
Subject: Re: [PATCH] cdrom: remove unused variable
Date: Fri,  1 Apr 2022 22:00:33 +0100	[thread overview]
Message-ID: <20220401210033.2078426-1-phil@philpotter.co.uk> (raw)
In-Reply-To: <20220401032623.293666-1-lienze@kylinos.cn>

> The clang static analyzer reports the following warning,
>
> File: drivers/cdrom/cdrom.c
> Warning: line 1380, column 7
> 	 Although the value stored to 'status' is used in enclosing
> 	 expression, the value is never actually read from 'status'
> 
> Remove the unused variable to eliminate the warning.
> 
> Signed-off-by: Enze Li <lienze@kylinos.cn>
> ---
>  drivers/cdrom/cdrom.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Looks good to me, thanks for the patch, will send on for inclusion in
5.18.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>

Regards,
Phil

      reply	other threads:[~2022-04-01 21:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-01  3:26 Enze Li
2022-04-01 21:00 ` Phillip Potter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220401210033.2078426-1-phil@philpotter.co.uk \
    --to=phil@philpotter.co.uk \
    --cc=lienze@kylinos.cn \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®