From: Johan Jonker <jbx6244@gmail.com>
To: heiko@sntech.de, zhangqing@rock-chips.com
Cc: robh+dt@kernel.org, krzk+dt@kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 16/16] dt-bindings: clock: fix some conversion clock issues for rockchip,rk3399-cru.yaml
Date: Sat, 2 Apr 2022 16:36:36 +0200 [thread overview]
Message-ID: <20220402143636.15222-17-jbx6244@gmail.com> (raw)
In-Reply-To: <20220402143636.15222-1-jbx6244@gmail.com>
With the YAML conversion somehow "assigned-xxx" properties where added.
If a proper clock is added to the cru node these properties are no longer
needed, so removed them.
With the conversion of rockchip,rk3399-cru.txt a table with external clocks
was copied. Include these clocks into the schema.
Add clocks and clocks-names to example and make them a requirement.
Reorder/restyle so that this file is line with the other Rockchip
CRU bindings.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
.../bindings/clock/rockchip,rk3399-cru.yaml | 55 ++++++++++---------
1 file changed, 28 insertions(+), 27 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml b/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml
index e91147c84..4574727da 100644
--- a/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml
+++ b/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml
@@ -20,15 +20,8 @@ description: |
used in device tree sources. Similar macros exist for the reset sources in
these files.
There are several clocks that are generated outside the SoC. It is expected
- that they are defined using standard clock bindings with following
- clock-output-names:
- - "xin24m" - crystal input - required,
- - "xin32k" - rtc clock - optional,
- - "clkin_gmac" - external GMAC clock - optional,
- - "clkin_i2s" - external I2S clock - optional,
- - "pclkin_cif" - external ISP clock - optional,
- - "clk_usbphy0_480m" - output clock of the pll in the usbphy0
- - "clk_usbphy1_480m" - output clock of the pll in the usbphy1
+ that they are defined using standard clock bindings with the
+ clock-output-names defined in this schema.
properties:
compatible:
@@ -39,37 +32,41 @@ properties:
reg:
maxItems: 1
- "#clock-cells":
- const: 1
-
- "#reset-cells":
- const: 1
-
clocks:
minItems: 1
+ maxItems: 7
- assigned-clocks:
- minItems: 1
- maxItems: 64
-
- assigned-clock-parents:
+ clock-names:
minItems: 1
- maxItems: 64
-
- assigned-clock-rates:
- minItems: 1
- maxItems: 64
+ maxItems: 7
+ items:
+ enum:
+ - xin24m
+ - xin32k
+ - clkin_gmac
+ - clkin_i2s
+ - clk_usbphy0_480m
+ - clk_usbphy1_480m
+ - pclkin_cif
rockchip,grf:
$ref: /schemas/types.yaml#/definitions/phandle
- description: >
- phandle to the syscon managing the "general register files". It is used
+ description:
+ Phandle to the syscon managing the "general register files". It is used
for GRF muxes, if missing any muxes present in the GRF will not be
available.
+ "#clock-cells":
+ const: 1
+
+ "#reset-cells":
+ const: 1
+
required:
- compatible
- reg
+ - clocks
+ - clock-names
- "#clock-cells"
- "#reset-cells"
@@ -80,6 +77,8 @@ examples:
pmucru: clock-controller@ff750000 {
compatible = "rockchip,rk3399-pmucru";
reg = <0xff750000 0x1000>;
+ clocks = <&xin24m>;
+ clock-names = "xin24m";
#clock-cells = <1>;
#reset-cells = <1>;
};
@@ -87,6 +86,8 @@ examples:
cru: clock-controller@ff760000 {
compatible = "rockchip,rk3399-cru";
reg = <0xff760000 0x1000>;
+ clocks = <&xin24m>;
+ clock-names = "xin24m";
#clock-cells = <1>;
#reset-cells = <1>;
};
--
2.20.1
next prev parent reply other threads:[~2022-04-02 14:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-02 14:36 [PATCH v4 00/16] Convert Rockchip clk Johan Jonker
2022-04-02 14:36 ` [PATCH v4 01/16] dt-bindings: clock: convert rockchip,px30-cru.txt to YAML Johan Jonker
2022-04-02 14:36 ` [PATCH v4 02/16] dt-bindings: clock: convert rockchip,rk3036-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 03/16] dt-bindings: clock: convert rockchip,rk3188-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 04/16] dt-bindings: clock: convert rockchip,rk3228-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 05/16] dt-bindings: clock: convert rockchip,rk3288-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 06/16] dt-bindings: clock: convert rockchip,rk3308-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 07/16] dt-bindings: clock: convert rockchip,rk3328-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 08/16] dt-bindings: clock: convert rockchip,rk3368-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 09/16] dt-bindings: clock: convert rockchip,rv1108-cru.txt " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 10/16] ARM: dts: rockchip: add clocks property to Rockchip cru nodes Johan Jonker
2022-04-02 14:36 ` [PATCH v4 11/16] arm64: " Johan Jonker
2022-04-02 14:36 ` [PATCH v4 12/16] arm64: dts: rockchip: rk3399: use generic node name for pmucru Johan Jonker
2022-04-02 14:36 ` [PATCH v4 13/16] arm64: dts: rockchip: fix compatible string rk3328 cru node Johan Jonker
2022-04-02 16:53 ` Krzysztof Kozlowski
2022-04-02 14:36 ` [PATCH v4 14/16] dt-bindings: clock: replace a maintainer for rockchip,rk3399-cru.yaml Johan Jonker
2022-04-02 14:36 ` [PATCH v4 15/16] dt-bindings: clock: use generic node name for pmucru example in rockchip,rk3399-cru.yaml Johan Jonker
2022-04-02 16:55 ` Krzysztof Kozlowski
2022-04-02 14:36 ` Johan Jonker [this message]
2022-04-02 16:45 ` [PATCH v4 00/16] Convert Rockchip clk Krzysztof Kozlowski
2022-04-02 16:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220402143636.15222-17-jbx6244@gmail.com \
--to=jbx6244@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®