From: Nava kishore Manne <nava.manne@xilinx.com>
To: <mdf@kernel.org>, <hao.wu@intel.com>, <yilun.xu@intel.com>,
<trix@redhat.com>, <michal.simek@xilinx.com>,
<linux-fpga@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <git@xilinx.com>
Cc: Nava kishore Manne <nava.manne@xilinx.com>
Subject: [PATCH v3 1/5] fpga: zynq: Fix incorrect variable type
Date: Sun, 3 Apr 2022 10:46:37 +0530 [thread overview]
Message-ID: <20220403051641.3867610-2-nava.manne@xilinx.com> (raw)
In-Reply-To: <20220403051641.3867610-1-nava.manne@xilinx.com>
zynq_fpga_has_sync () API is expecting "u8 *" but the
formal parameter that was passed is of type "const char *".
fixes this issue by changing the buf type to "const char *"
This patch will also update zynq_fpga_has_sync () API description
to align with API functionality.
Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
---
Changes for v2:
-None.
Changes for v3:
- Changed arg buf type to "const char *" as suggested by Tom.
drivers/fpga/zynq-fpga.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
index 426aa34c6a0d..ada07eea64bc 100644
--- a/drivers/fpga/zynq-fpga.c
+++ b/drivers/fpga/zynq-fpga.c
@@ -235,11 +235,11 @@ static irqreturn_t zynq_fpga_isr(int irq, void *data)
return IRQ_HANDLED;
}
-/* Sanity check the proposed bitstream. It must start with the sync word in
- * the correct byte order, and be dword aligned. The input is a Xilinx .bin
- * file with every 32 bit quantity swapped.
+/* Sanity check the proposed bitstream. The sync word must be found in the
+ * correct byte order and it should be dword aligned. The input is a
+ * Xilinx.bin file with every 32 bit quantity swapped.
*/
-static bool zynq_fpga_has_sync(const u8 *buf, size_t count)
+static bool zynq_fpga_has_sync(const char *buf, size_t count)
{
for (; count >= 4; buf += 4, count -= 4)
if (buf[0] == 0x66 && buf[1] == 0x55 && buf[2] == 0x99 &&
--
2.25.1
next prev parent reply other threads:[~2022-04-03 5:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 5:16 [PATCH v3 0/5]fpga: fix for coding style and kernel-doc issues Nava kishore Manne
2022-04-03 5:16 ` Nava kishore Manne [this message]
2022-04-05 4:38 ` [PATCH v3 1/5] fpga: zynq: Fix incorrect variable type Xu Yilun
2022-04-05 16:00 ` Russ Weight
2022-04-03 5:16 ` [PATCH v3 2/5] fpga: fix for coding style issues Nava kishore Manne
2022-04-03 5:16 ` [PATCH v3 3/5] fpga: fpga-mgr: Add missing kernel-doc description Nava kishore Manne
2022-04-03 5:16 ` [PATCH v3 4/5] fpga: Use tab instead of space indentation Nava kishore Manne
2022-04-03 5:16 ` [PATCH v3 5/5] fpga: fpga-region: Add missing kernel-doc description Nava kishore Manne
2022-04-05 5:35 ` Xu Yilun
2022-04-07 5:31 ` Nava kishore Manne
2022-04-07 6:48 ` Xu Yilun
2022-04-16 13:18 ` Nava kishore Manne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220403051641.3867610-2-nava.manne@xilinx.com \
--to=nava.manne@xilinx.com \
--cc=git@xilinx.com \
--cc=hao.wu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®