From: Tom Rix <trix@redhat.com>
To: dan.j.williams@intel.com, herbert@gondor.apana.org.au,
davem@davemloft.net, jarkko@kernel.org
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Rix <trix@redhat.com>
Subject: [PATCH] raid6test: change dataoffs from global to static
Date: Sun, 3 Apr 2022 09:30:51 -0400 [thread overview]
Message-ID: <20220403133051.3751572-1-trix@redhat.com> (raw)
Smatch reports this issue
raid6test.c:21:14: warning: symbol 'dataoffs'
was not declared. Should it be static?
dataoffs is only used in raid6test.c. File
scope variables used only in one file should
be static. Change dataoffs' storage-class-specifier
from global to static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
crypto/async_tx/raid6test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/async_tx/raid6test.c b/crypto/async_tx/raid6test.c
index c9d218e53bcb..d2d5fb154cda 100644
--- a/crypto/async_tx/raid6test.c
+++ b/crypto/async_tx/raid6test.c
@@ -18,7 +18,7 @@
#define NDISKS 64 /* Including P and Q */
static struct page *dataptrs[NDISKS];
-unsigned int dataoffs[NDISKS];
+static unsigned int dataoffs[NDISKS];
static addr_conv_t addr_conv[NDISKS];
static struct page *data[NDISKS+3];
static struct page *spare;
--
2.27.0
reply other threads:[~2022-04-03 13:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220403133051.3751572-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®