From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44687C433EF for ; Mon, 4 Apr 2022 23:13:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237701AbiDDXPI (ORCPT ); Mon, 4 Apr 2022 19:15:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243154AbiDDXOn (ORCPT ); Mon, 4 Apr 2022 19:14:43 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8971E24BD8; Mon, 4 Apr 2022 15:55:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 482E0B819DE; Mon, 4 Apr 2022 22:55:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B060DC2BBE4; Mon, 4 Apr 2022 22:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1649112918; bh=YJPKmsV50zrBbXBnSBP0IPEb8ro9ZtjvwhW0Jj1bEm8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pMccEIrlU08djbT7wpa1ZN4nuH6BttjslEaHrMrXBm3RIBKlSfoT0f/FcYT2iS3ls IYcRnNyMZ2Ls6Geib4sGfeWHOyVNPrHRYk5vsSDvKGz4SQVWlct+pYgglSnVLUFkJ2 f9M0YKMLgA0eGO3o2jNb33HftQnjOIzmrwYzIOVU= Date: Mon, 4 Apr 2022 15:55:16 -0700 From: Andrew Morton To: Jakob Koschel Cc: Mike Rapoport , David Hildenbrand , Oscar Salvador , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Brian Johannesmeyer , Cristiano Giuffrida , "Bos, H.J." Subject: Re: [PATCH] fs/proc/kcore.c: remove check of list iterator against head past the loop body Message-Id: <20220404155516.a5fb4c23ee017a7212e4b22c@linux-foundation.org> In-Reply-To: References: <20220331223700.902556-1-jakobkoschel@gmail.com> <20220331164843.b531fbf00d6e7afd6cdfe113@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Apr 2022 09:19:57 +0200 Jakob Koschel wrote: > > Speaking of limiting scope... > > Fair point :-) > > I see you have applied this already to the -mm tree. Shall I still move the iterator? > The hope is to remove the 'iter' variable altogether when there are no uses after > the loop anymore. I don't really understand the question. My plan is to merge your patch with my fixlet immediately prior to sending upstream.