From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5F38C46467 for ; Tue, 5 Apr 2022 22:39:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1453420AbiDEWdB (ORCPT ); Tue, 5 Apr 2022 18:33:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1388711AbiDENc5 (ORCPT ); Tue, 5 Apr 2022 09:32:57 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED00F5DE7F for ; Tue, 5 Apr 2022 05:34:26 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 235CYH0u099060; Tue, 5 Apr 2022 07:34:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1649162057; bh=JBTQpzbP72ROzzwlT8NhQDrUfP1RBqzG2+BjUn/g6Do=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=KwgVbuVcWyxfIZ+4pGRHsr8xUf+IpgKaPnSsiVFSF2Rncegc7Lxe8dL78ITJoErA7 yIKAbFPV/RUnVYDDL9qqphedyyE22iICSA/rvG3UgKx6eh8bBk8mHWA7KliU/KYXph HnjANKc6RS1fbzaZQM3uhDqrA8vvjxUBRKy3cT2Y= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 235CYHx1105259 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 5 Apr 2022 07:34:17 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Tue, 5 Apr 2022 07:34:17 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Tue, 5 Apr 2022 07:34:17 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 235CYHbc106836; Tue, 5 Apr 2022 07:34:17 -0500 Date: Tue, 5 Apr 2022 07:34:17 -0500 From: Nishanth Menon To: Julia Lawall CC: Nicolas Palix , , , Kirill Smelkov Subject: Re: [PATCH] coccinelle: api/stream_open: Introduce metavariables for checks Message-ID: <20220405123417.n6mdou64qidgsfo5@doing> References: <20220404215926.14811-1-nm@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08:17-20220405, Julia Lawall wrote: > > > On Mon, 4 Apr 2022, Nishanth Menon wrote: > > > Coccinelle spatch version 1.1.1 reports the following: > > warning: line 134: should no_llseek be a metavariable? > > warning: line 141: should noop_llseek be a metavariable? > > warning: line 223: should nonseekable_open be a metavariable? > > warning: line 290: should nonseekable_open be a metavariable? > > warning: line 338: should nonseekable_open be a metavariable? > > > > So, introduce the metavariable similar to other check instances. > > This changes the semantic from matching the specific thing to anything. > So are you sure that it is what is wanted? If it should always be the > specific thing, then you can get rid of the warning using eg symbol > no_llseek. Aaah thank you. Will post a v2 with s/identifier/symbol. I still need to grok the nuance between the two in [1]. Thanks for clarifying. [...] [1] https://coccinelle.gitlabpages.inria.fr/website/docs/main_grammar.html -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D