From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2204DC4167E for ; Wed, 6 Apr 2022 03:31:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2360434AbiDFDbb (ORCPT ); Tue, 5 Apr 2022 23:31:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1850366AbiDFCwO (ORCPT ); Tue, 5 Apr 2022 22:52:14 -0400 Received: from mail-wm1-x361.google.com (mail-wm1-x361.google.com [IPv6:2a00:1450:4864:20::361]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13278179B24 for ; Tue, 5 Apr 2022 16:52:09 -0700 (PDT) Received: by mail-wm1-x361.google.com with SMTP id q20so429212wmq.1 for ; Tue, 05 Apr 2022 16:52:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:content-transfer-encoding; bh=tjab0l+xfYR0aZEj5soCABbrSjfcWfiSiNw5bb6ADcc=; b=oHMkoc/XeuTktLvmTb8IuaP6YjKaiKEx6dD9wStDjI4atEzVVbGRAYxO+uYtD1HSib AHymz9LhwnZ46BwvGB1BwmvBCRAiZ+FU9oZ0sdQ7YVSIfDiGlJfB4BpJ4/jsOPParAVt tpiNSJi2ctk6Kyjb+JidG5nDrZZSIzOAJ3nvYUmBWhhecH67i9Cb/X3HEp0esE/Q3bOO 1jfrYr4le19YCrHgEz4ihfbrGOfahUzzPUSOWVKrQ1RpmbWXV3IubBpa4yENxymVFiHo Lx1cMgC0ivWsy6rE2hmrTDuuX7K3X+HKHici3xzEXVtTMwnqZY5ATFVfunZYbFK6G0JV 7w1w== X-Gm-Message-State: AOAM531Z0tq4loOzvoS8P8gPRbsN1I2a1uiYsQaXpmT/2PF5U/SJMiGy iBk0Qxysht4EeXzKjrtK8mwnNOfu+7GspL5yHDUkG/X8NSNz X-Google-Smtp-Source: ABdhPJzjXl9lYXef6+e9Ggc2Y85pcIUJDGm5uhvKfava0TB3KoHRk4M3HKy4QO+yz963G18cVxs/3dEmP3Ap X-Received: by 2002:a7b:c381:0:b0:37b:e01f:c1c0 with SMTP id s1-20020a7bc381000000b0037be01fc1c0mr5174267wmj.98.1649202721448; Tue, 05 Apr 2022 16:52:01 -0700 (PDT) Received: from smtp.aristanetworks.com (smtp.aristanetworks.com. [52.0.43.43]) by smtp-relay.gmail.com with ESMTPS id f13-20020a05600c4e8d00b0038c994092fbsm439961wmq.0.2022.04.05.16.52.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Apr 2022 16:52:01 -0700 (PDT) X-Relaying-Domain: arista.com Received: from chmeee (unknown [10.95.70.41]) by smtp.aristanetworks.com (Postfix) with ESMTPS id 28C603002D04; Tue, 5 Apr 2022 16:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=Arista-A; t=1649202720; bh=tjab0l+xfYR0aZEj5soCABbrSjfcWfiSiNw5bb6ADcc=; h=From:To:Cc:Subject:Date:From; b=woP9fF3qZzunKXrRcPgDSyac21eIvuWWbeTXc12/yEUdySijANk8sRKdptJl6l5cV iLcWQenoSPX2Ua0bGFCFKIClIsbbT65yMydGSEo0ET6l5uKpuHqFK61RohyHNSI0Kq N+MjUi8fnrUaLZTjxB92POD5qaaEiDgFmSq4TIzgFSShKcjV2p+U/2HajpkGw7oVwX Xbnd+gf0pkHohKyV6TZIsm4APNq+F+u8GWZm4iBIUbO2G1UxNT0QdN6rOWgHAL3CD+ qbi6ht0AIfArtaytZm0+cEir6F5+2bHfzNrmyt+2AcBxSrm/nEmbNJqmeleAy7LBGo xAWf0YU6uw5RQ== Received: from kevmitch by chmeee with local (Exim 4.95) (envelope-from ) id 1nbsxp-00188V-Sp; Tue, 05 Apr 2022 16:51:57 -0700 From: Kevin Mitchell Cc: kevmitch@arista.com, gal@nvidia.com, Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , Roopa Prabhu , Nikolay Aleksandrov , Alexey Kuznetsov , Hideaki YOSHIFUJI , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org Subject: [PATCH v2 0/1] UDP traceroute packets with no checksum Date: Tue, 5 Apr 2022 16:51:15 -0700 Message-Id: <20220405235117.269511-1-kevmitch@arista.com> Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is v2 of https://lkml.org/lkml/2022/1/14/1060 That patch was discovered to cause problems with UDP tunnels as described here: https://lore.kernel.org/netdev/7eed8111-42d7-63e1-d289-346a596fc933@nvidia.com/ This version addresses the issue by instead explicitly handling zero UDP checksum in the nf_reject_verify_csum() helper function. Unlike the previous patch, this one only allows zero UDP checksum in IPv4. I discovered that the non-netfilter IPv6 path would indeed drop zero UDP checksum packets, so it's probably best to remain consistent. -- 2.35.1