From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
mbenes@suse.cz, x86@kernel.org
Subject: Re: drivers/gpu/drm/i915/i915.prelink.o: warning: objtool: __intel_wait_for_register_fw.cold()+0xce: relocation to !ENDBR: vlv_allow_gt_wake.cold+0x0
Date: Wed, 6 Apr 2022 10:19:42 -0400 [thread overview]
Message-ID: <20220406101942.7abaf7dc@gandalf.local.home> (raw)
In-Reply-To: <20220406072913.GC34954@worktop.programming.kicks-ass.net>
On Wed, 6 Apr 2022 09:29:13 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> Best would be for Steve to send a patch removing them all:
>
>
> arch/powerpc/kvm/book3s_xics.c:#define XICS_DBG(fmt...) trace_printk(fmt)
> drivers/gpu/drm/i915/gt/intel_gtt.h:#define DBG(...) trace_printk(__VA_ARGS__)
> drivers/gpu/drm/i915/i915_gem.h:#define GEM_TRACE(...) trace_printk(__VA_ARGS__)
> drivers/gpu/drm/i915/i915_gem.h: trace_printk(__VA_ARGS__); \
> drivers/hwtracing/stm/dummy_stm.c: trace_printk("[%u:%u] [pkt: %x/%x] (%llx)\n", master, channel,
> drivers/infiniband/hw/hfi1/trace_dbg.h: trace_printk(fmt, ##__VA_ARGS__)
> drivers/tty/n_tty.c:# define n_tty_trace(f, args...) trace_printk(f, ##args)
> drivers/usb/early/xhci-dbc.c:#define xdbc_trace trace_printk
> fs/ext4/inline.c: trace_printk("inode %lu\n", dir->i_ino);
> fs/ext4/inline.c: trace_printk("de: off %u rlen %u name %.*s nlen %u ino %u\n",
>
>
> All except i915 use CPP tokens that don't exist, local developer really
> has to take effort to enable it. i915 crud depends on a CONFIG_ symbols
> that all{yes,mod}config will happily set for you,
As I replied to Josh, when trace_printk() is used, you get nasty dmesg
reports, and those do show up in bug reports to vendors (I laugh every time
I see them.)
I'm not too worried if trace_printk() is called for debugging, and even
with CONFIG_ options.
I even have trace_printk() used for things like my ring_buffer benchmark
(which should never be run on production!)
Thus, if the code that has trace_printk() is truly for debugging, and not
something that would normally get applied in other people's trees, then
that actually falls into its use case.
-- Steve
next prev parent reply other threads:[~2022-04-06 16:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 4:33 kernel test robot
2022-04-05 14:01 ` Peter Zijlstra
2022-04-06 0:05 ` Josh Poimboeuf
2022-04-06 0:46 ` Thomas Gleixner
2022-04-06 1:20 ` Steven Rostedt
2022-04-06 18:44 ` Arnaldo Carvalho de Melo
2022-04-06 5:32 ` Josh Poimboeuf
2022-04-06 7:29 ` Peter Zijlstra
2022-04-06 14:19 ` Steven Rostedt [this message]
2022-04-06 7:43 ` Peter Zijlstra
2022-04-06 16:37 ` Josh Poimboeuf
2022-04-07 9:24 ` Peter Zijlstra
2022-04-06 14:14 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406101942.7abaf7dc@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jpoimboe@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®