From: David Sterba <dsterba@suse.cz>
To: cgel.zte@gmail.com
Cc: dsterba@suse.cz, clm@fb.com, dsterba@suse.com,
josef@toxicpanda.com, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, lv.ruyi@zte.com.cn
Subject: Re: [PATCH] Btrfs: remove redundant judgment
Date: Thu, 7 Apr 2022 12:47:48 +0200 [thread overview]
Message-ID: <20220407104748.GD15609@twin.jikos.cz> (raw)
In-Reply-To: <20220407015700.2489671-1-lv.ruyi@zte.com.cn>
On Thu, Apr 07, 2022 at 01:57:00AM +0000, cgel.zte@gmail.com wrote:
> < Ok, we can drop the check, have you looked if there are more similar
> < places to update?
> I found six by coccinelle, but they are in different paths.Should I
> send one patch or six?
As this is a simple change it can be in one patch, provided that it's
the same logic (dropping inode check before iput).
I've found only 2 instances with this coccinelle script:
@@
expression E;
@@
* if (E)
* iput(E);
--
not sure where you found 6.
prev parent reply other threads:[~2022-04-07 10:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 9:04 cgel.zte
2022-04-06 13:04 ` David Sterba
2022-04-07 1:57 ` cgel.zte
2022-04-07 10:47 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407104748.GD15609@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=cgel.zte@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.ruyi@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®