From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D824EC433F5 for ; Thu, 7 Apr 2022 13:03:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231562AbiDGNF5 (ORCPT ); Thu, 7 Apr 2022 09:05:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343604AbiDGNFp (ORCPT ); Thu, 7 Apr 2022 09:05:45 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 511F725C5A6 for ; Thu, 7 Apr 2022 06:03:24 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KZ1l22cf4zdZhx; Thu, 7 Apr 2022 21:02:54 +0800 (CST) Received: from huawei.com (10.175.124.27) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 7 Apr 2022 21:03:22 +0800 From: Miaohe Lin To: , CC: , , , , , Subject: [PATCH 1/3] mm/memory-failure.c: avoid false-postive PageSwapCache test Date: Thu, 7 Apr 2022 21:03:50 +0800 Message-ID: <20220407130352.15618-2-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220407130352.15618-1-linmiaohe@huawei.com> References: <20220407130352.15618-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PageSwapCache is only reliable when PageAnon is true because PG_swapcache serves as PG_owner_priv_1 which can be used by fs if it's pagecache page. So we should test PageAnon to distinguish pagecache page from swapcache page to avoid false-postive PageSwapCache test. Signed-off-by: Miaohe Lin --- mm/memory-failure.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index ef402b490663..2e97302d62e4 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -2262,7 +2262,7 @@ static int __soft_offline_page(struct page *page) return 0; } - if (!PageHuge(page) && PageLRU(page) && !PageSwapCache(page)) + if (!PageHuge(page) && PageLRU(page) && !PageAnon(page)) /* * Try to invalidate first. This should work for * non dirty unmapped page cache pages. -- 2.23.0