mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Kitt <steve@sk2.org>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	Wolfram Sang <wsa@kernel.org>, Stephen Kitt <steve@sk2.org>
Subject: [PATCH v2 07/10] clk: si5351: use i2c_match_id and simple i2c probe
Date: Thu,  7 Apr 2022 17:18:28 +0200	[thread overview]
Message-ID: <20220407151831.2371706-8-steve@sk2.org> (raw)
In-Reply-To: <20220407151831.2371706-1-steve@sk2.org>

As part of the ongoing i2c transition to the simple probe
("probe_new"), this patch uses i2c_match_id to retrieve the
driver_data for the probed device. The id parameter is thus no longer
necessary and the simple probe can be used instead.

Signed-off-by: Stephen Kitt <steve@sk2.org>
---
 drivers/clk/clk-si5351.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
index 93fa8c9e11be..b9f088c4ba2f 100644
--- a/drivers/clk/clk-si5351.c
+++ b/drivers/clk/clk-si5351.c
@@ -1367,9 +1367,18 @@ si53351_of_clk_get(struct of_phandle_args *clkspec, void *data)
 }
 #endif /* CONFIG_OF */
 
-static int si5351_i2c_probe(struct i2c_client *client,
-			    const struct i2c_device_id *id)
+static const struct i2c_device_id si5351_i2c_ids[] = {
+	{ "si5351a", SI5351_VARIANT_A },
+	{ "si5351a-msop", SI5351_VARIANT_A3 },
+	{ "si5351b", SI5351_VARIANT_B },
+	{ "si5351c", SI5351_VARIANT_C },
+	{ }
+};
+MODULE_DEVICE_TABLE(i2c, si5351_i2c_ids);
+
+static int si5351_i2c_probe(struct i2c_client *client)
 {
+	const struct i2c_device_id *id = i2c_match_id(si5351_i2c_ids, client);
 	enum si5351_variant variant = (enum si5351_variant)id->driver_data;
 	struct si5351_platform_data *pdata;
 	struct si5351_driver_data *drvdata;
@@ -1649,21 +1658,12 @@ static int si5351_i2c_remove(struct i2c_client *client)
 	return 0;
 }
 
-static const struct i2c_device_id si5351_i2c_ids[] = {
-	{ "si5351a", SI5351_VARIANT_A },
-	{ "si5351a-msop", SI5351_VARIANT_A3 },
-	{ "si5351b", SI5351_VARIANT_B },
-	{ "si5351c", SI5351_VARIANT_C },
-	{ }
-};
-MODULE_DEVICE_TABLE(i2c, si5351_i2c_ids);
-
 static struct i2c_driver si5351_driver = {
 	.driver = {
 		.name = "si5351",
 		.of_match_table = of_match_ptr(si5351_dt_ids),
 	},
-	.probe = si5351_i2c_probe,
+	.probe_new = si5351_i2c_probe,
 	.remove = si5351_i2c_remove,
 	.id_table = si5351_i2c_ids,
 };
-- 
2.27.0


  parent reply	other threads:[~2022-04-07 15:28 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 15:18 [PATCH v2 00/10] clk: switch to simple i2c probe function Stephen Kitt
2022-04-07 15:18 ` [PATCH v2 01/10] clk: cdce706: use " Stephen Kitt
2022-04-07 20:09   ` Wolfram Sang
2022-04-07 20:15   ` Wolfram Sang
2022-04-23  2:32   ` Stephen Boyd
2022-04-07 15:18 ` [PATCH v2 02/10] clk: cdce925: use i2c_match_id and simple i2c probe Stephen Kitt
2022-04-07 20:13   ` Wolfram Sang
2022-04-23  2:32   ` Stephen Boyd
2022-04-07 15:18 ` [PATCH v2 03/10] clk: cs2000-cp: use simple i2c probe function Stephen Kitt
2022-04-07 20:14   ` Wolfram Sang
2022-04-23  2:32   ` Stephen Boyd
2022-04-07 15:18 ` [PATCH v2 04/10] clk: max9485: " Stephen Kitt
2022-04-07 20:14   ` Wolfram Sang
2022-04-23  2:33   ` Stephen Boyd
2022-04-07 15:18 ` [PATCH v2 05/10] clk: si514: " Stephen Kitt
2022-04-07 20:14   ` Wolfram Sang
2022-04-23  2:33   ` Stephen Boyd
2022-04-07 15:18 ` [PATCH v2 06/10] clk: si5341: " Stephen Kitt
2022-04-07 20:14   ` Wolfram Sang
2022-04-23  2:33   ` Stephen Boyd
2022-04-07 15:18 ` Stephen Kitt [this message]
2022-04-07 20:18   ` [PATCH v2 07/10] clk: si5351: use i2c_match_id and simple i2c probe Wolfram Sang
2022-04-23  2:34   ` Stephen Boyd
2022-04-07 15:18 ` [PATCH v2 08/10] clk: si544: " Stephen Kitt
2022-04-07 20:19   ` Wolfram Sang
2022-04-23  2:34   ` Stephen Boyd
2022-04-07 15:18 ` [PATCH v2 09/10] clk: si570: " Stephen Kitt
2022-04-07 20:19   ` Wolfram Sang
2022-04-23  2:35   ` Stephen Boyd
2022-04-07 15:18 ` [PATCH v2 10/10] clk: renesas-pcie: use simple i2c probe function Stephen Kitt
2022-04-07 20:19   ` Wolfram Sang
2022-04-23  2:35   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220407151831.2371706-8-steve@sk2.org \
    --to=steve@sk2.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®