mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
	rick.p.edgecombe@intel.com, jpoimboe@redhat.com,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 1/4] lib/strn*,objtool: Enforce user_access_begin() rules
Date: Fri, 08 Apr 2022 11:45:53 +0200	[thread overview]
Message-ID: <20220408094718.262932488@infradead.org> (raw)
In-Reply-To: <20220408094552.432447640@infradead.org>

Apparently GCC can fail to inline a 'static inline' single caller
function:

  lib/strnlen_user.o: warning: objtool: strnlen_user()+0x33: call to do_strnlen_user() with UACCESS enabled
  lib/strncpy_from_user.o: warning: objtool: strncpy_from_user()+0x33: call to do_strncpy_from_user() with UACCESS enabled

Reported-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 lib/strncpy_from_user.c |    2 +-
 lib/strnlen_user.c      |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--- a/lib/strncpy_from_user.c
+++ b/lib/strncpy_from_user.c
@@ -25,7 +25,7 @@
  * hit it), 'max' is the address space maximum (and we return
  * -EFAULT if we hit it).
  */
-static inline long do_strncpy_from_user(char *dst, const char __user *src,
+static __always_inline long do_strncpy_from_user(char *dst, const char __user *src,
 					unsigned long count, unsigned long max)
 {
 	const struct word_at_a_time constants = WORD_AT_A_TIME_CONSTANTS;
--- a/lib/strnlen_user.c
+++ b/lib/strnlen_user.c
@@ -20,7 +20,7 @@
  * if it fits in a aligned 'long'. The caller needs to check
  * the return value against "> max".
  */
-static inline long do_strnlen_user(const char __user *src, unsigned long count, unsigned long max)
+static __always_inline long do_strnlen_user(const char __user *src, unsigned long count, unsigned long max)
 {
 	const struct word_at_a_time constants = WORD_AT_A_TIME_CONSTANTS;
 	unsigned long align, res = 0;



  reply	other threads:[~2022-04-08  9:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  9:45 [PATCH 0/4] objtool: Fixes Peter Zijlstra
2022-04-08  9:45 ` Peter Zijlstra [this message]
2022-04-08 14:09   ` [PATCH 1/4] lib/strn*,objtool: Enforce user_access_begin() rules Josh Poimboeuf
2022-04-19 20:08   ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2022-04-08  9:45 ` [PATCH 2/4] x86,xen,objtool: Add UNWIND hint Peter Zijlstra
2022-04-19 20:08   ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2022-04-08  9:45 ` [PATCH 3/4] x86,objtool: Mark cpu_startup_entry() __noreturn Peter Zijlstra
2022-04-11 20:32   ` Josh Poimboeuf
2022-04-12 15:13   ` Josh Poimboeuf
2022-04-19 20:08   ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2022-04-08  9:45 ` [PATCH 4/4] x86,objtool: Explicitly mark idtentry_body()s tail REACHABLE Peter Zijlstra
2022-04-19 20:08   ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2022-04-08 14:10 ` [PATCH 0/4] objtool: Fixes Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220408094718.262932488@infradead.org \
    --to=peterz@infradead.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rick.p.edgecombe@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®