From: Daniel Thompson <daniel.thompson@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
SoC Team <soc@kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Sumit Garg <sumit.garg@linaro.org>,
Olof Johansson <olof@lixom.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Jiri Slaby <jirislaby@kernel.org>,
Jason Wessel <jason.wessel@windriver.com>,
Doug Anderson <dianders@chromium.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kgdb-bugreport@lists.sourceforge.net,
Peter Zijlstra <peterz@infradead.org>,
Mike Travis <mike.travis@hpe.com>
Subject: Re: [PATCH v3 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver
Date: Fri, 8 Apr 2022 16:02:02 +0100 [thread overview]
Message-ID: <20220408150202.yhn3qppqwm7wzmo3@maple.lan> (raw)
In-Reply-To: <CAK8P3a3v4+AO5avGoxeZSyNTOWqk8YS95xQLWSBZ=yV_3DKggg@mail.gmail.com>
On Fri, Apr 08, 2022 at 04:49:31PM +0200, Arnd Bergmann wrote:
> On Fri, Apr 8, 2022 at 4:21 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Apr 08, 2022 at 04:17:16PM +0200, Arnd Bergmann wrote:
> > > On Fri, Apr 8, 2022 at 3:32 PM Daniel Thompson
> > > <daniel.thompson@linaro.org> wrote:
> > > > On Thu, Mar 31, 2022 at 05:44:55PM +0200, Arnd Bergmann wrote:
> > > >
> > > > There is some prior art for this sort of feature. AFAICT SGI UV has a
> > > > similar mechanism that can send an NMI-with-no-side-channel to the
> > > > kernel. The corresponding driver offers a range of actions using a
> > > > module parameter:
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/x86/platform/uv/uv_nmi.c#n180
> > > >
> > > > I don't think a hardcoded 'c' makes any sense. With a hardcoded argument
> > > > it is just obfuscation. However it is certainly seems attractive to be
> > > > able to reuse handle_sysrq() to provide a more powerful set of actions.
> > >
> > > How about a module parameter that allows picking a sysrq character then?
> >
> > Module parameters are so 1990, as this is a platform device, why not get
> > it from DT?
>
> This machine doesn't use DT. I suppose the same could be done with an EFI
> variable, but with a module parameter you get the added benefit of having both
> a boot time kernel command line argument, and the option to override it at
> run time.
Pushing the decision on what action to take into firmware (whether that
is DT or ACPI) implies that the firmware is well positioned to make a
decision. I don't think that is true here.
To me, it seems more like an admin choice... and admins are conditioned
to use kernel arguments.
If these type of diagnostics request were more common then perhaps we'd
be looking at a sysctl and call to handle_diagnostic_sysrq().
Daniel.
next prev parent reply other threads:[~2022-04-08 15:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 9:22 [PATCH v3 0/1] " Hitomi Hasegawa
2022-03-31 9:22 ` [PATCH v3 1/1] " Hitomi Hasegawa
[not found] ` <YkWVTEG5oFO82GPL@kroah.com>
2022-03-31 15:44 ` Arnd Bergmann
2022-04-08 13:32 ` Daniel Thompson
2022-04-08 14:17 ` Arnd Bergmann
[not found] ` <YlBE6hZHmLo9/wrU@kroah.com>
2022-04-08 14:49 ` Arnd Bergmann
2022-04-08 15:02 ` Daniel Thompson [this message]
2022-04-19 8:36 ` hasegawa-hitomi
2022-04-28 2:15 ` hasegawa-hitomi
2022-04-28 7:04 ` Arnd Bergmann
2022-04-08 10:32 ` hasegawa-hitomi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220408150202.yhn3qppqwm7wzmo3@maple.lan \
--to=daniel.thompson@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=hasegawa-hitomi@fujitsu.com \
--cc=jason.wessel@windriver.com \
--cc=jirislaby@kernel.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mike.travis@hpe.com \
--cc=olof@lixom.net \
--cc=peterz@infradead.org \
--cc=soc@kernel.org \
--cc=sumit.garg@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®