mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Joel Fernandes <joel@joelfernandes.org>,
	Kalesh Singh <kaleshsingh@google.com>,
	Suren Baghdasaryan <surenb@google.com>,
	kernel-team <kernel-team@android.com>, Tejun Heo <tj@kernel.org>,
	Tim Murray <timmurray@google.com>, Wei Wang <wvw@google.com>,
	Kyle Lin <kylelin@google.com>, Chunwei Lu <chunweilu@google.com>,
	Lulu Wang <luluw@google.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	Neeraj Upadhyay <quic_neeraju@quicinc.com>,
	Josh Triplett <josh@joshtriplett.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>, rcu <rcu@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] EXP rcu: Move expedited grace period (GP) work to RT kthread_worker
Date: Fri, 8 Apr 2022 08:58:34 -0700	[thread overview]
Message-ID: <20220408155834.GI4285@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <20220408113946.056c083e@gandalf.local.home>

On Fri, Apr 08, 2022 at 11:39:46AM -0400, Steven Rostedt wrote:
> On Fri, 8 Apr 2022 06:21:03 -0400
> Joel Fernandes <joel@joelfernandes.org> wrote:
> 
> > > +       default !PREEMPT_RT && NR_CPUS <= 32  
> > 
> > What is the benefit of turning it off on PREEMPT_RT, even if
> > PREEMPT_RT does not use expedited GPs much post-boot? I would think in
> > the future if PREEMPT_RT ever uses expedited GPs, they would want this
> > feature even more. I'd rather be future-proof now as I don't see any
> > advantages of disabling it on !PREEMPT_RT (And a drawback that the fix
> > won't apply to those systems). Also will keep the config simple.
> 
> The default kthread priority is 1. This should not affect PREEMPT_RT, as
> PREEMPT_RT users are usually more concerned by the performance of their
> higher priority tasks. Priority 1 is not considered an issue.
> 
> I do not see why PREEMPT_RT is special here. Why was it singled out?

Because I didn't see the point of doing kthread_create_worker() to create
a pair of kthread_worker structuress that were never going to be used
in PREEMPT_RT kernels.

Or are PREEMPT_RT kernels no longer booting with rcupdate.rcu_normal?
Last I knew, they all did this to avoid IPI latencies from expedited
grace periods.  Has this changed?

							Thanx, Paul

  reply	other threads:[~2022-04-08 15:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  4:57 Kalesh Singh
2022-04-08 10:21 ` Joel Fernandes
2022-04-08 15:25   ` Paul E. McKenney
2022-04-08 15:39   ` Steven Rostedt
2022-04-08 15:58     ` Paul E. McKenney [this message]
2022-04-08 21:27       ` Steven Rostedt
2022-04-08 10:42 ` Joel Fernandes
2022-04-08 14:34   ` Paul E. McKenney
2022-04-08 14:41     ` Joel Fernandes
2022-04-08 15:34       ` Paul E. McKenney
2022-04-08 17:14         ` Joel Fernandes
2022-04-08 17:39           ` Paul E. McKenney
2022-04-08 17:53             ` Kalesh Singh
2022-04-08 21:42               ` Steven Rostedt
2022-04-08 22:06                 ` Kalesh Singh
     [not found]             ` <20220409071740.6024-1-hdanton@sina.com>
2022-04-09 15:56               ` Paul E. McKenney
     [not found]               ` <20220413113711.1263-1-hdanton@sina.com>
2022-04-13 14:07                 ` Paul E. McKenney
2022-04-13 17:21                   ` Joel Fernandes
2022-04-13 18:07                     ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220408155834.GI4285@paulmck-ThinkPad-P17-Gen-1 \
    --to=paulmck@kernel.org \
    --cc=chunweilu@google.com \
    --cc=frederic@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=kaleshsingh@google.com \
    --cc=kernel-team@android.com \
    --cc=kylelin@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luluw@google.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=quic_neeraju@quicinc.com \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=surenb@google.com \
    --cc=timmurray@google.com \
    --cc=tj@kernel.org \
    --cc=wvw@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®